Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "Example glob patterns" button and "close" button are not accessible using keyboard #3968

Merged
merged 5 commits into from
May 16, 2017
Merged

Fix: "Example glob patterns" button and "close" button are not accessible using keyboard #3968

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a34607
fix: tab access is enabled on disabled elements
skofman1 May 15, 2017
349dc93
make pretty
skofman1 May 15, 2017
2e0c4e7
Fix accessibility for popup close button
skofman1 May 15, 2017
c4a2cbf
Merge branch 'dev' into acc395308
skofman1 May 15, 2017
3eeecde
Add comments
skofman1 May 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/NuGetGallery/Views/Users/ApiKeys.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@
<a href="#" class="globHelpLink">Example glob patterns</a>.
<div class="popup">
<div class="popupbox" id="addapikeypopup">
<a class="boxclose"><i class="icon-remove"></i></a>
<a href="#" class="boxclose"><i class="icon-remove"></i></a>
<div class="innertext">
A glob pattern allows you to replace any sequence of characters with '*'.
<h5>Example glob patterns</h5>
Expand Down Expand Up @@ -599,11 +599,15 @@
$('.boxclose')
.click(function () {
$(this).parent().hide();
// Prevent page jump
return false;
});
$('.globHelpLink')
.click(function () {
$(this).next().find('.popupbox').show();
// Prevent page jump
return false;
});
}
</script>
Expand Down Expand Up @@ -1163,6 +1167,7 @@
popupboxDiv.className = "popupbox editapikeypopup";
var boxclose = document.createElement("a");
boxclose.className = "boxclose";
boxclose.href = "#";
var iconRemove = document.createElement("i");
iconRemove.className = "icon-remove";
boxclose.appendChild(iconRemove);
Expand Down