-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes en-us to improve documentation localization #9325
Conversation
[ReleasePrep][2022.11.09]RI of dev into main
[ReleasePre][2022.11.22] FI of dev into main
Did I break resource files on mac? I can't see CI so I won't know. |
Looks like we have some explicit assertions on the warning message.
We have the strings hard coded unit some unit tests, so these also need to be fixed up. C'mon man, throwing your mac under the bus so quickly? 😄 (I wouldn't have been surprised if some line ending stuff showed up :)) |
Will it take much work to fix the unit tests and merge this? Thanks! |
@joelverhagen @JonDouglas Thanks! |
@Mikejo5000, this is deployed to www.nuget.org now. Thanks for bringing attention to this! @JonDouglas, thanks for doing the hard work here! |
Summary of the changes (in less than 80 characters):
en-us
from many locations to improve documentation localization.