Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes en-us to improve documentation localization #9325

Merged
merged 4 commits into from
Jan 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/NUGETORG_ISSUE.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ body:
The more detail you provide, the more likely it will be for us to be able to identify what is going on and how to solve it!
### For issues connecting to NuGet.org, please refer to [this guide](https://docs.microsoft.com/en-us/nuget/nuget-org/nuget-org-faq#nuget.org-not-accessible).
### For issues connecting to NuGet.org, please refer to [this guide](https://docs.microsoft.com/nuget/nuget-org/nuget-org-faq#nuget.org-not-accessible).
### For issues regarding your NuGet.org account, please refer to [this guide](https://docs.microsoft.com/en-us/nuget/nuget-org/nuget-org-faq#nuget.org-account-management).
### For issues regarding your NuGet.org account, please refer to [this guide](https://docs.microsoft.com/nuget/nuget-org/nuget-org-faq#nuget.org-account-management).
- type: dropdown
id: impact
attributes:
Expand Down
4 changes: 2 additions & 2 deletions src/NuGetGallery.Services/ServicesStrings.resx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<root>
<!--
Microsoft ResX Schema
Expand Down Expand Up @@ -897,7 +897,7 @@ If you would like to update the linked Microsoft account you can do so from the
Policy violations: {0}</value>
</data>
<data name="SecurityPolicy_RequirePackagePrefixReserved" xml:space="preserve">
<value>You have not published a package with this prefix in the past. This means other users may be able to push packages starting with the same prefix. Contact account@nuget.org to reserve the prefix. Go to https://docs.microsoft.com/en-us/nuget/reference/id-prefix-reservation to learn more about Package ID prefix reservation.</value>
<value>You have not published a package with this prefix in the past. This means other users may be able to push packages starting with the same prefix. Contact account@nuget.org to reserve the prefix. Go to https://docs.microsoft.com/nuget/reference/id-prefix-reservation to learn more about Package ID prefix reservation.</value>
</data>
<data name="SecurityPolicy_CopyrightNotCompliant" xml:space="preserve">
<value>The package metadata contains a non-compliant copyright element.</value>
Expand Down
2 changes: 1 addition & 1 deletion src/NuGetGallery/App_Code/ViewHelpers.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
<p class="error-action">Get me out of here! <a href="@url.Home()">Go home</a></p>
<p class="error-action">Wondering if NuGet is down? <a href="https://status.nuget.org/">Check our status</a></p>
<p class="error-action">Looking for a package? <a href="@url.PackageList()">Try searching</a></p>
<p class="error-action">Package you're looking for doesn't exist? <a href="https://docs.microsoft.com/en-us/nuget/quickstart/create-and-publish-a-package">Make one</a></p>
<p class="error-action">Package you're looking for doesn't exist? <a href="https://docs.microsoft.com/nuget/quickstart/create-and-publish-a-package">Make one</a></p>
<p class="error-action">Pretty sure we messed up? <a href="https://github.com/NuGet/NuGetGallery/issues">File a bug</a></p>
<p class="error-action">Can't get enough NuGet? <a href="https://twitter.com/nuget">Follow us</a></p>
</div>
Expand Down
12 changes: 6 additions & 6 deletions src/NuGetGallery/Strings.resx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<root>
<!--
Microsoft ResX Schema
Expand Down Expand Up @@ -515,10 +515,10 @@ For more information, please contact '{2}'.</value>
<value>The ID prefix of this package has been reserved for one of the owners of this package by NuGet.org.</value>
</data>
<data name="UploadPackage_IdNamespaceConflict" xml:space="preserve">
<value>This package ID has been reserved. Please request access to upload to this reserved namespace from the owner of the reserved prefix, or re-upload the package with a different ID. Go to https://docs.microsoft.com/en-us/nuget/reference/id-prefix-reservation learn more about Package ID prefix reservation.</value>
<value>This package ID has been reserved. Please request access to upload to this reserved namespace from the owner of the reserved prefix, or re-upload the package with a different ID. Go to https://docs.microsoft.com/nuget/reference/id-prefix-reservation learn more about Package ID prefix reservation.</value>
</data>
<data name="UploadPackage_IdNamespaceConflictHtml" xml:space="preserve">
<value>This package ID has been reserved. Please request access to upload to this reserved namespace from the owner of the reserved prefix, or re-upload the package with a different ID. &lt;a href="https://docs.microsoft.com/en-us/nuget/reference/id-prefix-reservation"&gt;Learn more about Package ID prefix reservation&lt;/a&gt;.</value>
<value>This package ID has been reserved. Please request access to upload to this reserved namespace from the owner of the reserved prefix, or re-upload the package with a different ID. &lt;a href="https://docs.microsoft.com/nuget/reference/id-prefix-reservation"&gt;Learn more about Package ID prefix reservation&lt;/a&gt;.</value>
</data>
<data name="PreviewReadMe_ConversionFailed" xml:space="preserve">
<value>Conversion of Markdown to HTML failed with '{0}'.</value>
Expand All @@ -539,10 +539,10 @@ For more information, please contact '{2}'.</value>
<value>The Documentation URL must be a raw Markdown file hosted on GitHub.</value>
</data>
<data name="UploadPackage_MissingReadmeHtml" xml:space="preserve">
<value>&lt;strong&gt;Readme&lt;/strong&gt; missing.&lt;a href="https://learn.microsoft.com/en-us/nuget/create-packages/package-authoring-best-practices#readme"&gt; See how to include a readme file within the package&lt;/a&gt;, or add it as you upload.</value>
<value>&lt;strong&gt;Readme&lt;/strong&gt; missing.&lt;a href="https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme"&gt; See how to include a readme file within the package&lt;/a&gt;, or add it as you upload.</value>
</data>
<data name="UploadPackage_MissingReadme" xml:space="preserve">
<value>Readme missing. Go to https://learn.microsoft.com/en-us/nuget/create-packages/package-authoring-best-practices#readme learn How to include a readme file within the package.</value>
<value>Readme missing. Go to https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme learn How to include a readme file within the package.</value>
</data>
<data name="ReservedNamespace_OwnerAdded" xml:space="preserve">
<value>The user '{0}' is now an owner of the prefix '{1}'.</value>
Expand Down Expand Up @@ -909,7 +909,7 @@ If you would like to update the linked Microsoft account you can do so from the
Policy violations: {0}</value>
</data>
<data name="SecurityPolicy_RequirePackagePrefixReserved" xml:space="preserve">
<value>You have not published a package with this prefix in the past. This means other users may be able to push packages starting with the same prefix. Contact account@nuget.org to reserve the prefix. Go to https://docs.microsoft.com/en-us/nuget/reference/id-prefix-reservation to learn more about Package ID prefix reservation.</value>
<value>You have not published a package with this prefix in the past. This means other users may be able to push packages starting with the same prefix. Contact account@nuget.org to reserve the prefix. Go to https://docs.microsoft.com/nuget/reference/id-prefix-reservation to learn more about Package ID prefix reservation.</value>
</data>
<data name="SecurityPolicy_CopyrightNotCompliant" xml:space="preserve">
<value>The package metadata contains a non-compliant copyright element.</value>
Expand Down
6 changes: 3 additions & 3 deletions src/NuGetGallery/Views/Packages/DisplayPackage.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
CommandPrefix = "PM> ",
InstallPackageCommands = new [] { string.Format("NuGet\\Install-Package {0} -Version {1}", Model.Id, Model.Version) },
AlertLevel = AlertLevel.Info,
AlertMessage = "This command is intended to be used within the Package Manager Console in Visual Studio, as it uses the NuGet module's version of <a href='https://docs.microsoft.com/en-us/nuget/reference/ps-reference/ps-ref-install-package'>Install-Package</a>."
AlertMessage = "This command is intended to be used within the Package Manager Console in Visual Studio, as it uses the NuGet module's version of <a href='https://docs.microsoft.com/nuget/reference/ps-reference/ps-ref-install-package'>Install-Package</a>."

},

Expand All @@ -126,7 +126,7 @@
: string.Format("<PackageReference Include=\"{0}\" Version=\"{1}\" />", Model.Id, Model.Version) },
AlertLevel = AlertLevel.Info,
AlertMessage = string.Format("For projects that support <a href=\"{0}\">PackageReference</a>, copy this XML node into the project file to reference the package.",
"https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files"),
"https://docs.microsoft.com/nuget/consume-packages/package-references-in-project-files"),
CopyLabel = "Copy the PackageReference XML node",
},

Expand Down Expand Up @@ -274,7 +274,7 @@
@ViewHelpers.ImageFallback(Url.Absolute("~/Content/gallery/img/reserved-indicator-25x25.png"))
data-content="@Strings.ReservedNamespace_ReservedIndicatorTooltip" tabindex="0"
alt="@Strings.ReservedNamespace_ReservedIndicatorTooltip"/>
<a href="https://docs.microsoft.com/en-us/nuget/nuget-org/id-prefix-reservation" class="prefix-reserve-label">
<a href="https://docs.microsoft.com/nuget/nuget-org/id-prefix-reservation" class="prefix-reserve-label">
Prefix Reserved
</a>
</span>
Expand Down
2 changes: 1 addition & 1 deletion src/NuGetGallery/Views/Packages/ReportAbuse.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
</div>
<div class="reason-error-revenge-porn" tabindex="0">
<p>
Please report this safety violation through the <a href="https://www.microsoft.com/en-us/concern/revengeporn" title="revenge porn portal">official portal</a>.
Please report this safety violation through the <a href="https://www.microsoft.com/concern/revengeporn" title="revenge porn portal">official portal</a>.
</p>
</div>
<div id="report-abuse-form">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGetGallery/Views/Pages/Home.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ else if (AskUserToEnable2FA)
</div>
<div class="row row-gap">
<div class="col-sm-4">
<a href="https://docs.microsoft.com/en-us/nuget/quickstart/use-a-package"
<a href="https://docs.microsoft.com/nuget/quickstart/use-a-package"
title="Learn about how to use NuGet packages">
<img width="225" height="225" alt="Learn to use packages"
src="~/Content/gallery/img/orange-circle.svg"
Expand All @@ -108,7 +108,7 @@ else if (AskUserToEnable2FA)
</p>
</div>
<div class="col-sm-4">
<a href="https://docs.microsoft.com/en-us/nuget/quickstart/create-and-publish-a-package"
<a href="https://docs.microsoft.com/nuget/quickstart/create-and-publish-a-package"
title="Learn how to create a NuGet package">
<img width="225" height="225" alt="Learn to create packages"
src="~/Content/gallery/img/blue-circle.svg"
Expand Down
2 changes: 1 addition & 1 deletion src/NuGetGallery/Views/Shared/Gallery/Footer.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
</div>
<div class="col-sm-4">
<span class="footer-heading">
<a aria-label="Frequently Asked Questions" href="https://docs.microsoft.com/en-us/nuget/policies/nuget-faq">
<a aria-label="Frequently Asked Questions" href="https://docs.microsoft.com/nuget/policies/nuget-faq">
<abbr title="Frequently Asked Questions">FAQ</abbr>
</a>
</span>
Expand Down
2 changes: 1 addition & 1 deletion src/NuGetGallery/Views/Shared/Gallery/Header.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
{
@DisplayNavigationItem("Admin", Url.Admin())
}
@DisplayNavigationItem("Documentation", "https://docs.microsoft.com/en-us/nuget/")
@DisplayNavigationItem("Documentation", "https://docs.microsoft.com/nuget/")
@DisplayNavigationItem("Downloads", Url.Downloads())
@DisplayNavigationItem("Blog", "https://blog.nuget.org/")
</ul>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@

<div class="row" data-bind="ifnot: $data && $data.hasCertificates && $data.hasCertificates()">
<div class="col-xs-12 clearfix">
All your packages need to be signed by one of the registered certificates. <a href="https://docs.microsoft.com/en-us/nuget/reference/signed-packages-reference">Learn more about package signing.</a>
All your packages need to be signed by one of the registered certificates. <a href="https://docs.microsoft.com/nuget/reference/signed-packages-reference">Learn more about package signing.</a>
<br /> <br />
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/NuGetGallery/Views/Users/ApiKeys.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<br />
<p>
<strong>Note:</strong> To push packages to nuget.org you must use <a href="https://www.nuget.org/downloads">nuget.exe v4.1.0 or above</a>,
which implements the required <a href="https://docs.microsoft.com/en-us/nuget/api/nuget-protocols">NuGet protocols</a>.
which implements the required <a href="https://docs.microsoft.com/nuget/api/nuget-protocols">NuGet protocols</a>.
</p>
</p>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1500,8 +1500,8 @@ public async Task WarnsAboutPackagesWithoutReadmeWhenDisplayUploadWarningV2Enabl
Assert.Null(result.Message);
var warning = Assert.Single(result.Warnings);
Assert.IsType<UploadPackageMissingReadme>(warning);
Assert.StartsWith("Readme missing. Go to https://learn.microsoft.com/en-us/nuget/create-packages/package-authoring-best-practices#readme learn How to include a readme file within the package.", warning.PlainTextMessage);
Assert.StartsWith("<strong>Readme</strong> missing.<a href=\"https://learn.microsoft.com/en-us/nuget/create-packages/package-authoring-best-practices#readme\"> See how to include a readme file within the package</a>, or add it as you upload.", warning.RawHtmlMessage);
Assert.StartsWith("Readme missing. Go to https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme learn How to include a readme file within the package.", warning.PlainTextMessage);
Assert.StartsWith("<strong>Readme</strong> missing.<a href=\"https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme\"> See how to include a readme file within the package</a>, or add it as you upload.", warning.RawHtmlMessage);
}

[Fact]
Expand All @@ -1527,8 +1527,8 @@ public async Task WarnsAboutPackagesWithoutWhenEmbeddedReadmeNotEnabledAndDispla
Assert.Null(result.Message);
var warning = Assert.Single(result.Warnings);
Assert.IsType<UploadPackageMissingReadme>(warning);
Assert.StartsWith("Readme missing. Go to https://learn.microsoft.com/en-us/nuget/create-packages/package-authoring-best-practices#readme learn How to include a readme file within the package.", warning.PlainTextMessage);
Assert.StartsWith("<strong>Readme</strong> missing.<a href=\"https://learn.microsoft.com/en-us/nuget/create-packages/package-authoring-best-practices#readme\"> See how to include a readme file within the package</a>, or add it as you upload.", warning.RawHtmlMessage);
Assert.StartsWith("Readme missing. Go to https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme learn How to include a readme file within the package.", warning.PlainTextMessage);
Assert.StartsWith("<strong>Readme</strong> missing.<a href=\"https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme\"> See how to include a readme file within the package</a>, or add it as you upload.", warning.RawHtmlMessage);
}

private async Task<PackageValidationResult> ValidatePackageWithReadme(string readmePath, byte[] readmeFileData)
Expand Down