Solve Package Page Tooltip Accessibility Bugs and Framework Filter Checkbox List Accessibility Bug #9900
Conversation
Goodyear2017
changed the title
src/NuGetGallery/Views/Packages/_SupportedFrameworksBadges.cshtml
Outdated
Show resolved
Hide resolved
src/NuGetGallery/Content/Site.css
Outdated
| @@ -1726,3 +1726,36 @@ img.contributors-contributor-avatar { | |||
| font-size: 1.1em; | |||
| padding: 5px 15px 5px 15px; | |||
| } | |||
| /* Packages page tooltip */ | |||
There was a problem hiding this comment.
Sometimes we make changes in both css and less file.
@martinrrm could please review this one?
There was a problem hiding this comment.
I just move the css to less and compile the css file. BTW, do I need to submit .min file for the js file?
Goodyear2017
dismissed
erdembayar’s stale review
The merge-base changed after approval.
|
@Goodyear2017 |
|
@erdembayar Please see the attached videos for before and after. |
It's very hard for me to know difference between 2 videos, just screenshots would have been better. |
Goodyear2017
force-pushed
the
lilixie3-1970893-1970906-1987964
branch
from
4900eb2 to
7322c13
Compare
| @@ -1,92 +0,0 @@ | |||
| name: NuGetGallery CI $(Build.BuildId) | |||
There was a problem hiding this comment.
Why do we need to remove these files? Or where these changes come from?
|
@martinrrm I have no clue where the files come from, I will close this PR and make a new one. |
|
I will close this PR and make a new one. |
Disable Bootstrap popover JavaScript on framework filter and support framework badges, keep the popover classes and layout, add JavaScript function to make the tooltip popup, narrator can read the tooltip.
Add up and down arrow key JavaScript function to make users are able to use arrow keys to move between framework filter mode checkboxes.
Bug links: