Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Link Screen Reading Issue On Upload Package Page And About Page #9903

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

Goodyear2017
Copy link
Contributor

@Goodyear2017 Goodyear2017 commented Apr 3, 2024

@Goodyear2017 Goodyear2017 requested a review from a team as a code owner April 3, 2024 19:57
@mariaghiondea mariaghiondea requested review from sbanni and ryuyu April 3, 2024 19:59
@ryuyu
Copy link
Contributor

ryuyu commented Apr 3, 2024

Can we add links to the relevant bugs in the description for this, #9901 and #9900 ? Thanks!

@Goodyear2017
Copy link
Contributor Author

@ryuyu Just added the links to PRs, thanks!

@erdembayar
Copy link
Contributor

Could you please include screenshot for that change if available?

@Goodyear2017
Copy link
Contributor Author

@erdembayar The change is for the link "Best Practices". Because we put a aria-label inside the link, screen reader reads the aria-label content instead of "best practices", removing the aria-label solve the issue.
image

@ryuyu ryuyu merged commit fbe8c04 into NuGet:dev Apr 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants