Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isSupported when feature name is not in db #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cloudfroster
Copy link

Bug

when use

isSupported('notTheCssName', 'chrome')

occur error : Cannot read property 'stats' of undefined

break change

no

@Nyalab
Copy link
Owner

Nyalab commented Mar 2, 2018

if the feature name does not exist, we should throw a ReferenceError, not fail silently, could you revise the code so it does that please?

if you look at the isSupported tests, the third one should test that in theory, why does it not work?

(you need to rebase your work on master so it works with the current version of caniuse-lite)

@neenhouse
Copy link

This is implemented in a better version here: #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants