-
Notifications
You must be signed in to change notification settings - Fork 9.1k
v3.2: Refactor and streamline OpenAPI Description Structure sections (take 2) #4927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Remove "OpenAPI Description" and "OpenAPI Document" section headings and reorder those paragraphs and the intro "OpenAPI Description Structure" paragraph to define the terms inline * Switch Appendixes F and G * F->G stays as-is, with base URI examples * G->F is expanded to a more general "Parsing and Resolution Guidance" section * Move several pieces of "Parsing Documents" to Appendix G * How to parse complete documents as the intro section * A "Warnings Regarding Fragmentary Parsing" section * Move "Structural Interoperability" under Appendix G and rename it to "Conflicts Between Field Types and Reference Contexts" * Move most of "Resolving Implicit Connections to Appendix G and rename it "Guidance Regarding Implicit Connections" * Put the original Section F implicit connection examples as a "Implicit Connection Resolution Examples" subsection Minimal adjustments were made to links to keep the build functional.
A lot of what was here is no longer needed, and other things can be said better either because of the new arrangement or because I thought of better wording since I first wrote things. In particular, get rid of the awkward Document vs document distinction by banishing discussion of small-d documents to the appendix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, only one nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
Also added a commit to fix the inaccurate statement about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Replacement for PR #4918 – please review carefully, I've rewritten this too many times across too many widely separated days which is getting a bit confusing for me.
This further streamlines things and gets rid of "Document" vs "document" by banishing discussion of what had been "documents" to Appendix G, and saying that unless otherwise specified, "document" (regardless of capitalization) refers to documents having either an OpenAPI Object or Schema Object at the root.
I have updated the rendered page on my personal github pages.
This has two commits (one for moves, one for changes, more or less) as with #4918.
Please let me know if you want other ways of looking at diffs that I did for that other PR.