Skip to content

Conversation

handrews
Copy link
Member

@handrews handrews commented Sep 8, 2025

See discussion #4233 and issue #4147. Requiring the patch version is creating tremendous amounts of confusion. While we cannot seem to reach consensus on forbidding it, there has long been a consensus on not requiring it. Let's at least do that.

Also, the regex in the schema allowed for -something in the openapi field, which is not part of the OAS field definition at all so I removed it. We used to do -rcN releases, but we have no plan to do so for 3.2 anyway, and we ought not further overload an already confusing mechanism. If we need to note a pre-release version in the future, let's add a field for it.

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@handrews handrews added this to the v3.2.0 milestone Sep 8, 2025
@handrews handrews requested review from a team as code owners September 8, 2025 15:52
@handrews handrews added the metadata tags, info, license, contact, markdown usage, etc. label Sep 8, 2025
@lornajane
Copy link
Contributor

I am not in favour of introducing this change for 3.2 and delaying the release again. This is not a review of the change, but a logistical point. Please do not introduce changes for 3.2, and instead target this for 3.3 and we can review it there.

@handrews
Copy link
Member Author

handrews commented Sep 8, 2025

@lornajane this is not a delay. There is a simple change that we had consensus on at one point. The amount of problems this is causing right now is worth the completely trivial amount of work to merge this PR.

ralfhandl
ralfhandl previously approved these changes Sep 8, 2025
@ralfhandl ralfhandl requested a review from a team September 8, 2025 16:14
earth2marsh
earth2marsh previously approved these changes Sep 8, 2025
Copy link
Member

@earth2marsh earth2marsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of this change, though whether it should be in 3.2 or 3.3 MUST be resolved before this is merged.

@ralfhandl ralfhandl requested review from a team and lornajane September 8, 2025 16:45
@karenetheridge
Copy link
Member

PLEASE DON'T MERGE this until the discussion on the relevant issues has concluded.

@handrews
Copy link
Member Author

handrews commented Sep 8, 2025

@karenetheridge this is still a problem regardless of what happens with schema $ids.

Also remove what looked to be a part of the regex allowing for
"-rcN" suffixes, which are not mentioned in the field definition
at all.
@handrews
Copy link
Member Author

handrews commented Sep 9, 2025

Rebased and force-pushed because of the merge of PR #4927, but there are no actual changes to the commits/text here (both touched the openapi field text but this PR already incorporated the change from 4927).

@handrews
Copy link
Member Author

handrews commented Sep 9, 2025

@ralfhandl should be fixed now.

@handrews
Copy link
Member Author

@karenetheridge this PR still allows the point release to be present if people want to do something with it. Without opening another thread here on any other aspects, does that make any difference to you? Nothing you're doing now with point releases would be impossible after this for any OAD author who wants to specify the point release.

This PR just allows authors who want to make it very clear that they are using 3.2 in its most clarified/least buggy form, whatever that is, to say so.

@mikekistler
Copy link
Contributor

We discussed this in the 9/11/25 TDC meeting and could not get consensus on whether this should go in 3.2 or 3.3.

@karenetheridge karenetheridge modified the milestones: v3.2.0, v3.3.0 Sep 11, 2025
@handrews
Copy link
Member Author

handrews commented Sep 11, 2025

I have made my points here and elsewhere. I will be traveling and will not be able to make next week's TDC call, but I encourage folks to make a decision one way or the other and ship the release in my absence. I feel like folks have listened sufficiently to what I have to say on this topic, so I don't need to be present for any final call.

Please feel free to edit the PR or replace it with another one if editing this one is inconvenient. I do not need to approve any edits.

@ralfhandl
Copy link
Contributor

I vote for including this in v3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata tags, info, license, contact, markdown usage, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants