Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_tax_balance: Migration to 16.0 #937

Merged
merged 65 commits into from
Nov 11, 2022
Merged

[16.0][MIG] account_tax_balance: Migration to 16.0 #937

merged 65 commits into from
Nov 11, 2022

Conversation

ramiadavid
Copy link
Contributor

No description provided.

eLBati and others added 5 commits October 20, 2022 22:11
@eLBati @ramiadavid
[ADD] account_tax_balance: Compute tax balances based on date range
4c88180
@gfcapalbo @ramiadavid
tests
10384e3
@eLBati @ramiadavid
[FIX+IMP] account_tax_balance:
473c54e 
* Tests
* PEP8
* Use invoice._convert_to_write(invoice._cache). This way, the onchange will be inheritable and will add here also the added values
* better get_context_values
* unify method compute_balance
* open move lines linked to balance
@antespi @ramiadavid
Consider normal and refund operations separately
2bdeb1f 
Allow to explore all move lines

Spanish translation

Bugfixes

Show negative lines too

Show move type in account.move views

Tests include new fields
@sbidoul @ramiadavid
[MIG] account_tax_balance 10.0
e5f5ff2
@ramiadavid ramiadavid mentioned this pull request Oct 27, 2022
Open
7 tasks
@ramiadavid ramiadavid force-pushed the 16.0-mig-account_tax_balance branch from 4328ed2 to 5cd930d Compare October 27, 2022 18:15
@ramiadavid
Copy link
Contributor Author

Hi @pedrobaeza
The tests are fine, but I'm not 100% sure if the change from internal_type to account_type is correct, if you can check it.
Thank you

@ramiadavid ramiadavid marked this pull request as ready for review October 27, 2022 18:18
@TheMule71 TheMule71 mentioned this pull request Nov 2, 2022
Merged
@tafaRU tafaRU mentioned this pull request Nov 11, 2022
Open
79 tasks
tafaRU
tafaRU requested changes Nov 11, 2022
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM except for ramiadavid#1
--edit--: please also squash administrative commits (if any) with the previous commit for reducing commit noise.

Thanks a lot!

eLBati
eLBati approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@tafaRU
Copy link
Member

tafaRU commented Nov 11, 2022

@ramiadavid thanks for merging my PR! Please also squash administrative commits, then your PR is ready for the merge 👍

@pedrobaeza
Copy link
Member

/ocabot migration account_tax_balance

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 11, 2022
@tafaRU
Copy link
Member

tafaRU commented Nov 11, 2022

@ramiadavid let me know if you need help for merging the squash administrative commits.

@pedrobaeza
Copy link
Member

I'm improving the guide for this. I'm pasting the link when finish.

@ramiadavid
Copy link
Contributor Author

@ramiadavid let me know if you need help for merging the squash administrative commits.

If you can explain me how to do it correctly, I would appreciate it, because I don't want to do it wrong

@pedrobaeza
Copy link
Member

Uf, it has taken more time than expected, but I hope they are good enough:

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

Please tell any suggestion to it.

eLBati and others added 10 commits November 11, 2022 13:39
@eLBati @ramiadavid
[FIX+IMP] account_tax_balance:
6a8cc2b 
* Test
* README
* add extra parent menu. If not, with the web_responsive module is mixed
  between other menus
@StefanRijnhart @ramiadavid
[FIX] Include tax amounts from all move types
b9cdcc3
@sbidoul @ramiadavid
[IMP] account_tax_balance: performance
b604ac4 
Let the database do some computations (sum) and do not
put large lists of ids in action domain.
@sbidoul @ramiadavid
[IMP] account_tax_balance: faster search of taxes with moves
c41b939
@sbidoul @ramiadavid
account_tax_balance: improve test coverage
4f70e6d
@ramiadavid
add condition tax_exigible in domain variable
d611bca
@sbidoul @ramiadavid
[IMP] account_tax_balance: add index
508801e 
This indexes improve the display time of
account_tax_balance by a factor of 10 on a database
with 1M move lines.
@pedrobaeza @ramiadavid
[MIG] account_tax_balance: Migration to 11.0
94fcd31
@JordiBForgeFlow @ramiadavid
dynamize general ledger
f5ebe29
@pedrobaeza @ramiadavid
[IMP] account_tax_balance: Change tests to post instal and protect ag…
fd9c2d1 
…ain freezes
@ramiadavid ramiadavid force-pushed the 16.0-mig-account_tax_balance branch from 78e6237 to 6ad3e20 Compare November 11, 2022 12:39
@ramiadavid
Copy link
Contributor Author

@tafaRU @pedrobaeza I think it is ready

@tafaRU
Copy link
Member

tafaRU commented Nov 11, 2022

@ramiadavid you missed one:

image

@pedrobaeza
Copy link
Member

I think that one of the cases where a conflict arises.

@ramiadavid
Copy link
Contributor Author

@tafaRU I'm not sure how to do this, since it causes a conflict

@pedrobaeza
Copy link
Member

@tafaRU can you please update your review?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-937-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 750772d into OCA:16.0 Nov 11, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8ab16dd. Thanks a lot for contributing to OCA. ❤️

@ramiadavid ramiadavid deleted the 16.0-mig-account_tax_balance branch November 11, 2022 13:22
@Gelo-fl
Copy link

Gelo-fl commented Jun 1, 2023

Hi @dreispt,

This module is merged, however the translations are locked:
account-financial-reporting-16.0-account_tax_balance
Can I know why?

Thanks in advance,

@pedrobaeza
Copy link
Member

Unlocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafaRU tafaRU tafaRU approved these changes

@eLBati eLBati eLBati approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.