Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] l10n_it_account #2990

Merged
merged 94 commits into from
Nov 11, 2022
Merged

[16.0] [MIG] l10n_it_account #2990

merged 94 commits into from
Nov 11, 2022

Conversation

TheMule71
Copy link
Contributor

@TheMule71 TheMule71 commented Nov 2, 2022 •
edited
Loading

@TheMule71 TheMule71 force-pushed the 16.0-mig-l10n_it_account branch from 898ee11 to 0b083a0 Compare November 2, 2022 02:39
@TheMule71 TheMule71 mentioned this pull request Nov 2, 2022
Open
79 tasks
@SirTakobi
Copy link
Contributor

@TheMule71 puoi includere PR aperte modificando il test-requirements.txt invece di fare 0b083a0.
Se le includi nel test-requirements.txt è automaticamente impossibile mergiare questa PR per sbaglio perché fa fallire il check Detect unreleased dependencies

This was referenced Nov 2, 2022
Merged
Merged
Merged
@TheMule71 TheMule71 force-pushed the 16.0-mig-l10n_it_account branch 3 times, most recently from 21b5776 to 75aa5b4 Compare November 2, 2022 18:04
@TheMule71
Copy link
Contributor Author

@TheMule71 puoi includere PR aperte modificando il test-requirements.txt invece di fare 0b083a0. Se le includi nel test-requirements.txt è automaticamente impossibile mergiare questa PR per sbaglio perché fa fallire il check Detect unreleased dependencies

Ottimo, grazie. Le altre PR (le nostre) mi preoccupano già di meno, i commit sparirebbero comunque se fossero identici, causerebbero conflict se fossero diversi.

@TheMule71 TheMule71 mentioned this pull request Nov 2, 2022
Merged
@SirTakobi
Copy link
Contributor

@TheMule71 puoi includere PR aperte modificando il test-requirements.txt invece di fare 0b083a0. Se le includi nel test-requirements.txt è automaticamente impossibile mergiare questa PR per sbaglio perché fa fallire il check Detect unreleased dependencies

Ottimo, grazie. Le altre PR (le nostre) mi preoccupano già di meno, i commit sparirebbero comunque se fossero identici, causerebbero conflict se fossero diversi.

Anche per le nostre PR, è comunque meglio usare i requirements per non rischiare di mergiare diverse PR insieme e per non dover fare continui rebase quando cambia l'altra PR

@TheMule71
Copy link
Contributor Author

Anche per le nostre PR, è comunque meglio usare i requirements per non rischiare di mergiare diverse PR insieme e per non dover fare continui rebase quando cambia l'altra PR

Ho inziato a farlo da fatturapa_out (esclusa) in poi. Il fatto è che così devo riesumare il supermerge (cosa che volevo evitare), perché non sono testabili fuori da github senza fare il merge a mano.

@primes2h
Copy link
Contributor

primes2h commented Nov 8, 2022

/ocabot migration l10n_it_account

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 8, 2022
@TheMule71 TheMule71 marked this pull request as ready for review November 10, 2022 10:12
SirTakobi
SirTakobi suggested changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@SirTakobi SirTakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
In TheMule71#31 ho fatto le modifiche di cui abbiamo parlato e anche qualcos'altro, che ne pensi?

@TheMule71 TheMule71 force-pushed the 16.0-mig-l10n_it_account branch from 885fc8c to 8532e7f Compare November 11, 2022 08:16
SirTakobi
SirTakobi suggested changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@SirTakobi SirTakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheMule71 mi sembra si siano perse le modifiche di TheMule71#31 nel rebase

@TheMule71 TheMule71 force-pushed the 16.0-mig-l10n_it_account branch from 8532e7f to 96e4d7b Compare November 11, 2022 10:35
eLBati and others added 9 commits November 11, 2022 11:48
@eLBati @TheMule71
l10n_it: splittato in l10n_it_base, l10n_it_account e l10n_it_sale
33fa114
@TheMule71
[IMP] added sale order -> invoice cross-reference (useful to access s…
c9f08f2 
…hipping data from the invoice -> "fattura accompagnatoria")

removed sale addon dependency from l10n_it_account
various changes...just for fun
ADD funzionalità compatibili solo con la V6
@TheMule71
FIX doppio step del wizard produceva giornali doppi
8c53ffd 
updating branch structure
@TheMule71
[IMP] openerp v6 compatibility improvements
9f176e5 
[FIX] fixed compat issues
@TheMule71
ADD relation region -> country
84233de 
l10n_it_account: FIX translations

l10n_it_account: FIX translations

l10n_it_account: ADD fiscal code computation

l10n_it_account: FIX error validating invoice

l10n_it: FIX naming and removing dependency from other modules

ADD l10n_it_ri_ba
@eLBati @TheMule71
FIX dependency from l10n_it_base removed
342eea1 
ADD l10n_it_account dependency from account_sequence

FIX l10n_it_account, missing dependency

FIX http://www.openerp-italia.org/index.php?option=com_kunena&Itemid=66&func=view&catid=29&id=4060#4060

[IMP] l10n_it_account: descrizione più esplicativa

[FIX] invoice check for supplier refund

Removing dependency from account_sequence:
https://bugs.launchpad.net/openobject-italia/+bug/949900
https://bugs.launchpad.net/openobject-addons/+bug/950629
account_sequence will probably be a dependency of the 'libro giornale' module

[FIX] copyright

[del] l10n_it_account
not tested on trunk
@TheMule71
[ADD] l10n_it_account
b27a0d6 
[FIX] v8 compat

[IMP] i18n

[IMP] folders/files structure

[ADD] common paper formats

[FIX] missing view import

[FIX] paper orientation

[ADD] undeductable field on account.tax

[FIX] removed empty keys

[FIX] removed active key

[IMP] standard footer

[IMP] negative balance helpers for BS report

[FIX] report title

[FIX] terms for non deductible tax

[FIX] typos

[IMP] i18n

[FIX] terms
@DAMilani @TheMule71
Modificata stampa registri Iva
e7495e2 
Controllo su univocità conti imposte per le imposte di acquisto
@eLBati @TheMule71
[ADD] tests for l10n_it_account
182ed29
SimoRubi and others added 11 commits November 11, 2022 11:51
@SimoRubi @TheMule71
[FIX] l10n_it_account: Recompute (un)deductible balance for different…
f84818e 
… dates
@primes2h @TheMule71
Translated using Weblate (Italian)
7bcab37 
Currently translated at 92.5% (25 of 27 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_account
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_account/it/
@Borruso @TheMule71
[14.0][IMP] l10n_it_account: manage multi-company report
024711c
@OCA-git-bot @TheMule71
[IMP] update dotfiles
82a0d35
@TheMule71
[FIX] l10n_it_account: fix test tags
6c69b65
@TheMule71
[IMP] FPA Schema tools
a0ee859
@tafaRU @TheMule71
[FIX] l10n_it_account: fix error during vat statement calculation
f22ee83 
Traceback (most recent call last):
File "/.repo_requirements/odoo/odoo/http.py", line 640, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/.repo_requirements/odoo/odoo/http.py", line 316, in _handle_exception
raise exception.with_traceback(None) from new_cause
AttributeError: 'account.tax' object has no attribute 'account_id'

It closes OCA#2577
@TheMule71
[IMP] upgrade FatturaPA specs and stylesheets to v1.7.1
e0ae4d4
@TheMule71
[IMP] l10n_it_account: pre-commit stuff
7e239b5
@TheMule71
[MIG] l10n_it_account: Migration to 16.0
5c29ce1
@TheMule71
[MIG] l10n_it_account: Migration to 16.0 - remove account.account.type
acfcaf8
@TheMule71 TheMule71 force-pushed the 16.0-mig-l10n_it_account branch from c0a6e61 to 3f4e419 Compare November 11, 2022 10:52
@TheMule71 TheMule71 force-pushed the 16.0-mig-l10n_it_account branch from 3f4e419 to 5652ec4 Compare November 11, 2022 15:25
tafaRU
tafaRU requested changes Nov 11, 2022
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review tecnica basata su TheMule71/l10n-italy@TheMule71:l10n-italy:5b6aed0650616352588f5c2aaf707ca0dd37e92c~5...TheMule71:l10n-italy:5b6aed0650616352588f5c2aaf707ca0dd37e92c

account_tax_balance è stato mergiata: puoi togliere la PR da https://github.com/TheMule71/l10n-italy/blob/16.0-mig-l10n_it_account/test-requirements.txt?

l10n_it_account/readme/DESCRIPTION.rst Outdated

Used by modules like l10n_it_vat_registries and account_vat_period_end_statement

Notice: the migratiob script hasn't been tested.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/migrationb/migration 😉

@TheMule71 TheMule71 force-pushed the 16.0-mig-l10n_it_account branch 2 times, most recently from 2507a36 to 9d65aed Compare November 11, 2022 15:46
@eLBati
Copy link
Member

eLBati commented Nov 11, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2990-by-eLBati-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d7b5d06 into OCA:16.0 Nov 11, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d9ed800. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirTakobi SirTakobi SirTakobi approved these changes

@tafaRU tafaRU tafaRU approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.