[14.0][IMP] account_asset_management: big code cleanup

[alexis-via]

Use fields.Monetary() instead of fields.Float()
Use odoo's compare and round methods for floats
Add check_company=True where relevant
Stop using "Account" decimal precision... it doesn't exist any more! Replace compute() by _convert() for currency conversion

[rvalyi]

LGTM

[pedrobaeza]

Why not using currency_id name for the field and avoid all the explicit currency_field for cleaning a bit more?

[alexis-via]

@pedrobaeza yes, why not. But "company_currency_id" is more meaningful, because the developper immediately understands that the currency of the field is from the company, not from a specific field of the asset.

[pedrobaeza]

But the asset is handled in such currency, so the company meaning doesn't matter. In fact, if in the future a multi-currency asset system is put, we will have currency_id and company_currency_id, but this one would be converted to company_id, not to company_currency_id (although both will initialize as the same).

[pedrobaeza]

@alexis-via do you see my explanation to simplify to currency_id and avoid to explicitly indicate the currency field?

[alexis-via]

/ocabot merge major

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1513-by-alexis-via-bump-major, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at b53fa7e. Thanks a lot for contributing to OCA. ❤️

[luc-demeyer]

great job ! Thanks.
Who will cherry-pick this to 15.0 and 16.0 ?

[MiquelRForgeFlow]

@luc-demeyer
Knowing Akretion's aversion to odd versions of odoo, I took a dose of solidarity to migrate this to version 15.0 in #1606.

Also good news: FYI, no need to migrate this to v16.