Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] account_asset_management: big code cleanup (forward port) #1606

Closed
wants to merge 1 commit into from
Closed

[15.0][IMP] account_asset_management: big code cleanup (forward port) #1606

wants to merge 1 commit into from

Conversation

MiquelRForgeFlow
Copy link
Contributor

Forward port of #1513.

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 15-asset-code-cleanup branch 2 times, most recently from b556e9e to 1487fe1 Compare March 10, 2023 10:24
@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Mar 10, 2023
Merged
AaronHForgeFlow
AaronHForgeFlow approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲 LGTM

bosd
bosd approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronHForgeFlow
Copy link
Contributor

@pedrobaeza this was merged in v14 is it ok to you to move this to 15 and newer versions?

@pedrobaeza pedrobaeza added this to the 15.0 milestone Oct 2, 2023
pedrobaeza
pedrobaeza requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take into account my comment in #1513 (comment)

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 14, 2024
@bosd
Copy link
Contributor

bosd commented Jul 15, 2024

uuh ooh, almost stale..
@MiquelRForgeFlow Do you plan on continue to work on this one?

@alexis-via @MiquelRForgeFlow
[IMP] account_asset_management: big code cleanup
f9b0e04 
Use fields.Monetary() instead of fields.Float()
Use odoo's compare and round methods for floats
Add check_company=True where relevant
Stop using "Account" decimal precision... it doesn't exist any more!
Replace compute() by _convert() for currency conversion
@MiquelRForgeFlow
Copy link
Contributor Author

Rebased.

@bosd , no, I can't dedicate more time on this, as I am full with other projects.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 21, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 24, 2024
@github-actions github-actions bot closed this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

@bosd bosd bosd approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@MiquelRForgeFlow @AaronHForgeFlow @bosd @pedrobaeza @OCA-git-bot @alexis-via