[14.0] [FIX] sale_commission_check_deposit: do not filter non deposited checks #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renda-dev
force-pushed
the
14.0-imp-sale_commission_check_deposit-date_maturity
branch
from
b5fac2d
to
df08169
Compare
renda-dev
changed the title
renda-dev
force-pushed
the
14.0-imp-sale_commission_check_deposit-date_maturity
branch
from
df08169
to
71c9257
Compare
renda-dev
force-pushed
the
14.0-imp-sale_commission_check_deposit-date_maturity
branch
from
71c9257
to
713210a
Compare
renda-dev
force-pushed
the
14.0-imp-sale_commission_check_deposit-date_maturity
branch
from
713210a
to
43f80d8
Compare
francesco-ooops
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Functional ok!
Removed constraint on validated checks, improved description and "Safety days for commission" calculation logic
@pedrobaeza good for merge?
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 0a9284a. Thanks a lot for contributing to OCA. ❤️ |
PicchiSeba
deleted the
14.0-imp-sale_commission_check_deposit-date_maturity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.