Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [IMP] l10n_it_riba_sale_commission: use wizard's payment date #4284

Merged
merged 2 commits into from
Jul 22, 2024
Merged

[14.0] [IMP] l10n_it_riba_sale_commission: use wizard's payment date #4284

merged 2 commits into from
Jul 22, 2024

Conversation

renda-dev
Copy link
Contributor

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @odooNextev,
some modules you are maintaining are being modified, check this out!

@francesco-ooops
Copy link
Contributor

Issue non necessaria in quanto modulo non presente in v16

Modifica sulla falsa riga di OCA/commission#543 per verificare che siano passati i giorni di sicurezza tra la scadenza della RiBa e il limite temporale di pagamento delle provvigioni impostato nella wizard delle liquidazioni

@renda-dev
Copy link
Contributor Author

Propongo anche me ed il mio team come maintainers del modulo

@renda-dev renda-dev force-pushed the 14.0-imp-l10n_it_riba_sale_commission branch 2 times, most recently from 389e5b4 to 834300d Compare July 22, 2024 08:54
francesco-ooops
francesco-ooops approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funzionale ok!

Più FIX che IMP perchè non rispondeva effettivamente alla descrizione:

Il filtro per la data di pagamento, nel caso di un pagamento Riba, scarterà tutti
i pagamenti dove non sono passati almeno i "Giorni di sicurezza" rispetto alla
data di scadenza.

PicchiSeba
PicchiSeba reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@PicchiSeba PicchiSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: LGTM

Potential DOC issue

l10n_it_riba_sale_commission/README.rst Outdated Show resolved Hide resolved
l10n_it_riba_sale_commission/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
@renda-dev renda-dev force-pushed the 14.0-imp-l10n_it_riba_sale_commission branch from b9aa6a0 to 834300d Compare July 22, 2024 10:13
@renda-dev renda-dev force-pushed the 14.0-imp-l10n_it_riba_sale_commission branch from 834300d to 8d36833 Compare July 22, 2024 12:21
@odooNextev
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-4284-by-odooNextev-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ea761a6 into OCA:14.0 Jul 22, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9cd558f. Thanks a lot for contributing to OCA. ❤️

@PicchiSeba PicchiSeba deleted the 14.0-imp-l10n_it_riba_sale_commission branch July 22, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PicchiSeba PicchiSeba PicchiSeba left review comments

@francesco-ooops francesco-ooops francesco-ooops approved these changes

Assignees
No one assigned
Labels
14.0 merged 🎉 no issue needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@renda-dev @OCA-git-bot @francesco-ooops @odooNextev @PicchiSeba