[9.0][ADD] crm_phonecall module #131

cubells · 2017-01-24T05:23:09Z

Extracted model from crm module to manage phone calls.
Addition is needed for users who want to analyze those calls, imputed times and much more.

WIP because I'm working on tests now.

cc @Tecnativa

pedrobaeza

Excellent work extracting, passing to new API and testing some parts. A little more to do in my comments for improving still more and we were good to go.

pedrobaeza · 2017-01-31T13:13:30Z

crm_phonecall/README.rst

+Contributors
+------------
+
+* Vicent Cubells <vicent.cubells@tecnativa.com>


Put Odoo S. A.

pedrobaeza · 2017-01-31T13:13:41Z

crm_phonecall/__init__.py

@@ -0,0 +1,8 @@
+# -*- coding: utf-8 -*-
+##############################################################################


Use new header style

pedrobaeza · 2017-01-31T13:13:52Z

crm_phonecall/__openerp__.py

+    "name": "CRM Phone Calls",
+    "version": "9.0.1.0.0",
+    "category": "Customer Relationship Management",
+    "author": "Tecnativa, "


Include Odoo S. A.

pedrobaeza · 2017-01-31T13:15:28Z

crm_phonecall/models/res_partner.py

+    phonecall_count = fields.Integer(
+        compute='_phonecall_count',
+        string="Phonecalls",
+        copy=False,


Being computed, copy and default are ignored.

pedrobaeza · 2017-01-31T13:17:29Z

crm_phonecall/report/crm_phonecall_report.py

+from openerp import tools
+from openerp import fields, models
+
+AVAILABLE_STATES = [


Why don't you take it from the same source instead of creating the list 2 times?

This list is created only one time.

pedrobaeza · 2017-01-31T13:18:32Z

crm_phonecall/report/crm_phonecall_report.py

+
+        tools.drop_view_if_exists(cr, 'crm_phonecall_report')
+        cr.execute("""
+            create or replace view crm_phonecall_report as (


Make this report inheritable extracting the SQL parts in methods as you already seen in for example invoices.

pedrobaeza · 2017-01-31T13:20:23Z

crm_phonecall/wizard/crm_phonecall_to_phonecall.py

+                tag_id = data_obj.browse(res_id).res_id
+            except ValueError:
+                pass
+            if 'name' in fields:


You can do here a loop here for avoiding too much code:

for field in ('name', 'user_id'...): if field in fields: res[field] = getattr(phonecall, field)

pedrobaeza · 2017-01-31T13:20:49Z

crm_phonecall/wizard/crm_phonecall_to_phonecall.py

+            phonecalls.schedule_another_phonecall(
+                this.date,
+                this.name,
+                this.user_id.id or False,


No need of the or False

pedrobaeza · 2017-01-31T16:44:35Z

Other comment from migration (for at least avoiding a crash):

Rename on a migration script the group called "Show Scheduled Calls Menu" (group_scheduled_calls)

pedrobaeza · 2017-01-31T17:44:16Z

Another thing: you need to rename ir.filters from crm.phonecall.report or there will be a duplicated name error.

cubells · 2017-02-01T19:49:56Z

I'll rebase on pass tests...

alexcbr2

Functionallity checked but you can only access Sales >
Configuration > Leads & Opportunities > Phone Calls > Categories if you are in developer mode.

luismontalba

Tested on runbot

This module is the part extracted from Odoo v8 crm module from Odoo that allows to record phone calls. As it has been stripped off from Odoo v9, we add again the feature via this module. Migration scripts are also included to upgrade a v8 database via OpenUpgrade and don't lose your history.

* crm_phonecall module (#131) This module is the part extracted from Odoo v8 crm module from Odoo that allows to record phone calls. As it has been stripped off from Odoo v9, we add again the feature via this module. Migration scripts are also included to upgrade a v8 database via OpenUpgrade and don't lose your history. * [MIG] crm_phone_call: Migrated to 10.0 - FIX: Correct some lint errors * [MIG] crm_phone_call: Migrated to 10.0

* crm_phonecall module (OCA#131) This module is the part extracted from Odoo v8 crm module from Odoo that allows to record phone calls. As it has been stripped off from Odoo v9, we add again the feature via this module. Migration scripts are also included to upgrade a v8 database via OpenUpgrade and don't lose your history. * [MIG] crm_phone_call: Migrated to 10.0 - FIX: Correct some lint errors * [MIG] crm_phone_call: Migrated to 10.0

[9.0][ADD][WIP] crm_phonecall module

6c764da

cubells force-pushed the 9.0-mig-crm_phonecall branch 2 times, most recently from 5f01d4a to b6a2e0b Compare January 24, 2017 21:22

Added tests

b047f17

cubells force-pushed the 9.0-mig-crm_phonecall branch from b6a2e0b to b047f17 Compare January 31, 2017 04:14

cubells mentioned this pull request Jan 31, 2017

[9.0][MIG] crm_phonecall_summary_predefined module #132

Merged

1 task

pedrobaeza requested changes Jan 31, 2017

View reviewed changes

Some improvements requested

a6eba81

cubells force-pushed the 9.0-mig-crm_phonecall branch from 9f24772 to a6eba81 Compare January 31, 2017 19:36

cubells mentioned this pull request Feb 1, 2017

[FIX] crm_phonecall migration OCA/OpenUpgrade#752

Merged

cubells force-pushed the 9.0-mig-crm_phonecall branch 10 times, most recently from d154c06 to 6c26edc Compare February 3, 2017 04:18

Rename xmlids to avoid conflict

bc7a6b0

cubells force-pushed the 9.0-mig-crm_phonecall branch from 6c26edc to bc7a6b0 Compare February 3, 2017 04:30

[IMP] crm_phonecall: Change menu sequence

68b7e3b

rafaelbn added the needs review label Feb 27, 2017

rafaelbn added this to the 9.0 milestone Feb 27, 2017

rafaelbn changed the title ~~[9.0][ADD][WIP] crm_phonecall module~~ [9.0][ADD] crm_phonecall module Mar 1, 2017

alexcbr2 reviewed Mar 1, 2017

View reviewed changes

rafaelbn approved these changes Mar 24, 2017

View reviewed changes

pedrobaeza approved these changes Mar 24, 2017

View reviewed changes

luismontalba approved these changes Mar 24, 2017

View reviewed changes

pedrobaeza merged commit f4a3394 into OCA:9.0 Mar 24, 2017

pedrobaeza deleted the 9.0-mig-crm_phonecall branch March 24, 2017 16:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.0][ADD] crm_phonecall module #131

[9.0][ADD] crm_phonecall module #131

cubells commented Jan 24, 2017 •

edited by pedrobaeza

Loading

pedrobaeza left a comment

pedrobaeza Jan 31, 2017

pedrobaeza Jan 31, 2017

pedrobaeza Jan 31, 2017

pedrobaeza Jan 31, 2017

pedrobaeza Jan 31, 2017

cubells Jan 31, 2017

pedrobaeza Jan 31, 2017

pedrobaeza Jan 31, 2017

pedrobaeza Jan 31, 2017

pedrobaeza commented Jan 31, 2017

pedrobaeza commented Jan 31, 2017

cubells commented Feb 1, 2017

alexcbr2 left a comment

luismontalba left a comment

		@@ -0,0 +1,8 @@
		# -- coding: utf-8 --
		##############################################################################

[9.0][ADD] crm_phonecall module #131

[9.0][ADD] crm_phonecall module #131

Conversation

cubells commented Jan 24, 2017 • edited by pedrobaeza Loading

pedrobaeza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Jan 31, 2017

pedrobaeza commented Jan 31, 2017

cubells commented Feb 1, 2017

alexcbr2 left a comment

Choose a reason for hiding this comment

luismontalba left a comment

Choose a reason for hiding this comment

cubells commented Jan 24, 2017 •

edited by pedrobaeza

Loading