[MIG] crm_phone_call: Migrated to 10.0 #138

cubells · 2017-03-31T08:11:47Z

This module is the part extracted from Odoo v8 crm module from Odoo that allows to record phone calls. As it has been stripped off from Odoo v9, we add again the feature via this module. Migration scripts are also included to upgrade a v8 database via OpenUpgrade and don't lose your history.

chienandalu · 2017-03-31T09:45:55Z

crm_phonecall/README.rst

+   call contact to opportunity.
+* Calls can be categorized and you can manage categories in *Sales >
+   Configuration > Leads & Opportunities > Phone Calls > Categories*.
+* Calls can be analyzed in *Sales > Reports > Phone Calls Analysis*.


wrong rst formating (bold inside bold)

No, * delimiting a text means an italic text.

chienandalu

missing funcionality

pedrobaeza · 2017-03-31T11:39:30Z

crm_phonecall/README.rst

+   :alt: License: AGPL-3
+
+==============
+Crm Phonecalls


CRM phone calls

pedrobaeza · 2017-03-31T11:40:48Z

crm_phonecall/README.rst

+
+To use this module, you need to:
+
+* Go to *Sales > Phone Calls > Logged Calls > Create*.


Use #. for a numbered list instead a bullet list. Check that indentation of the second line is correct (with the new delimiter, it will, as it requires 3 space, but now, it should be 2, as the text starts in that position).

pedrobaeza · 2017-03-31T11:42:56Z

crm_phonecall/README.rst

+   call contact to opportunity.
+* Calls can be categorized and you can manage categories in *Sales >
+   Configuration > Leads & Opportunities > Phone Calls > Categories*.
+* Calls can be analyzed in *Sales > Reports > Phone Calls Analysis*.


No, * delimiting a text means an italic text.

pedrobaeza · 2017-03-31T11:44:03Z

crm_phonecall/__init__.py

+from . import report
+
+
+xmlid_renames = [


These hooks should be removed for version 10, as it only applies to version 9 (although they don't fail as there's an if condition first).

pedrobaeza · 2017-03-31T11:44:25Z

crm_phonecall/__manifest__.py

+        'report/crm_phonecall_report_view.xml',
+    ],
+    'installable': True,
+    "pre_init_hook": "rename_xmlids_hook",


Remove the hook.

pedrobaeza · 2017-03-31T11:48:04Z

Check also these beta messages from the linter:

crm_phonecall/views/crm_phonecall_view.xml:93: [W7910(wrong-tabs-instead-of-spaces), ]  Use wrong tabs indentation instead of four spaces
crm_phonecall/models/res_partner.py:18: [C8108(method-compute), ResPartner] Name of compute method should starts with "_compute_"
crm_phonecall/report/crm_phonecall_report.py:128: [E8103(sql-injection), CrmPhonecallReport.init] Use of "%" operator in execute database method. Better use parameters instead. - More info https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#no-sql-injection

pedrobaeza · 2017-03-31T11:48:52Z

@chienandalu what do you mean with "missing funcionality"? It's not explained in the README?

- FIX: Correct some lint errors

chienandalu · 2017-03-31T17:16:11Z

Sorry, @pedrobaeza my request was really poor. I'll try to explain with better detail:

The screenshot I attached before was a capture from a runbot with v9 crm_phone_call. I put in a red square the icon that serve to take different actions on every call you register.
That's what's missing in this migration for the moment:

cubells · 2017-03-31T17:17:50Z

thanks @chienandalu

I'll review.

pedrobaeza · 2017-03-31T17:35:58Z

You have to change to Font awesome icons (fa-...). In v10, GTK icons have been removed.

pedrobaeza

Only code review

chienandalu

Functionality is ok now 😄

rafaelbn

Tested functionally

* crm_phonecall module (OCA#131) This module is the part extracted from Odoo v8 crm module from Odoo that allows to record phone calls. As it has been stripped off from Odoo v9, we add again the feature via this module. Migration scripts are also included to upgrade a v8 database via OpenUpgrade and don't lose your history. * [MIG] crm_phone_call: Migrated to 10.0 - FIX: Correct some lint errors * [MIG] crm_phone_call: Migrated to 10.0

rafaelbn added the needs review label Mar 31, 2017

rafaelbn added this to the 10.0 milestone Mar 31, 2017

chienandalu reviewed Mar 31, 2017

View reviewed changes

chienandalu suggested changes Mar 31, 2017

View reviewed changes

pedrobaeza requested changes Mar 31, 2017

View reviewed changes

pedrobaeza closed this Mar 31, 2017

pedrobaeza reopened this Mar 31, 2017

[MIG] crm_phone_call: Migrated to 10.0

c25e699

- FIX: Correct some lint errors

cubells force-pushed the 10.0-mig-crm_phonecall branch from b02700a to c25e699 Compare March 31, 2017 13:56

cubells changed the title ~~10.0 mig crm phonecall~~ [MIG] crm_phone_call: Migrated to 10.0 Mar 31, 2017

[MIG] crm_phone_call: Migrated to 10.0

93cadde

pedrobaeza approved these changes Apr 4, 2017

View reviewed changes

chienandalu approved these changes Apr 4, 2017

View reviewed changes

rafaelbn approved these changes Apr 4, 2017

View reviewed changes

rafaelbn merged commit 537df3d into OCA:10.0 Apr 4, 2017

pedrobaeza deleted the 10.0-mig-crm_phonecall branch April 5, 2017 07:19

pedrobaeza mentioned this pull request Apr 5, 2017

Migration to version 10.0 #117

Closed

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] crm_phone_call: Migrated to 10.0 #138

[MIG] crm_phone_call: Migrated to 10.0 #138

cubells commented Mar 31, 2017

chienandalu Mar 31, 2017

pedrobaeza Mar 31, 2017

chienandalu left a comment

pedrobaeza Mar 31, 2017

pedrobaeza Mar 31, 2017

pedrobaeza Mar 31, 2017

pedrobaeza Mar 31, 2017

pedrobaeza Mar 31, 2017

pedrobaeza commented Mar 31, 2017

pedrobaeza commented Mar 31, 2017

chienandalu commented Mar 31, 2017

cubells commented Mar 31, 2017

pedrobaeza commented Mar 31, 2017

pedrobaeza left a comment

chienandalu left a comment

rafaelbn left a comment


		To use this module, you need to:

		* Go to Sales > Phone Calls > Logged Calls > Create.

[MIG] crm_phone_call: Migrated to 10.0 #138

[MIG] crm_phone_call: Migrated to 10.0 #138

Conversation

cubells commented Mar 31, 2017

chienandalu Mar 31, 2017

Choose a reason for hiding this comment

pedrobaeza Mar 31, 2017

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

pedrobaeza Mar 31, 2017

Choose a reason for hiding this comment

pedrobaeza Mar 31, 2017

Choose a reason for hiding this comment

pedrobaeza Mar 31, 2017

Choose a reason for hiding this comment

pedrobaeza Mar 31, 2017

Choose a reason for hiding this comment

pedrobaeza Mar 31, 2017

Choose a reason for hiding this comment

pedrobaeza commented Mar 31, 2017

pedrobaeza commented Mar 31, 2017

chienandalu commented Mar 31, 2017

cubells commented Mar 31, 2017

pedrobaeza commented Mar 31, 2017

pedrobaeza left a comment

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

rafaelbn left a comment

Choose a reason for hiding this comment