Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] delivery_send_to_shipper_at_operation: Keep delivery_notification_sent set on backorder #782

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

mt-software-de
Copy link
Contributor

@mt-software-de mt-software-de commented Mar 14, 2024

If a backorder is created out of a transfer which is marked as delivery_notification_sent = True.
The backorder should also be marked as delivery_notification_sent.

@jbaudoux @TDu

Depends on:
Fixing tests
#786

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we simply revert this #720 ?

@mt-software-de
Copy link
Contributor Author

Why can't we simply revert this #720 ?

No it is fine to not copy the value, because move_dest_ids/move_orig_ids will also not copied from a move.
In a backorder case the move_orig_ids will be the same as in the new backorder

@jbaudoux
Copy link
Contributor

@mt-software-de I should have added a unittest for my fix #720. If you do a partial pack, then you don't want to keep delivery_notification_sent on the pack backorder.
So, it's a bit more complex...

@mt-software-de
Copy link
Contributor Author

@mt-software-de I should have added a unittest for my fix #720. If you do a partial pack, then you don't want to keep delivery_notification_sent on the pack backorder. So, it's a bit more complex...

For the pack operation backorder it is fine, to not set the delivery_notification_sent
therefore we need to remove

@mt-software-de mt-software-de force-pushed the 14-fix-delivery_send_to_shipper_at_operation-backorder branch 3 times, most recently from 57f8c4b to fdb7424 Compare March 18, 2024 23:51
@rousseldenis rousseldenis added this to the 14.0 milestone Mar 19, 2024
@mt-software-de mt-software-de force-pushed the 14-fix-delivery_send_to_shipper_at_operation-backorder branch 2 times, most recently from 78b5e82 to 116a601 Compare March 20, 2024 08:17
@mt-software-de mt-software-de force-pushed the 14-fix-delivery_send_to_shipper_at_operation-backorder branch from 116a601 to 7352e84 Compare April 10, 2024 15:03
@mt-software-de mt-software-de changed the title [FIX] delivery_send_to_shipper_at_operation: Keep delivery_notification_sent set on backorder [14.0][FIX] delivery_send_to_shipper_at_operation: Keep delivery_notification_sent set on backorder Apr 15, 2024
@mt-software-de mt-software-de force-pushed the 14-fix-delivery_send_to_shipper_at_operation-backorder branch 4 times, most recently from c8c52ec to ef147b5 Compare April 17, 2024 15:35
Keep delivery_notification_sent set on backorder
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 18, 2024
@github-actions github-actions bot closed this Sep 22, 2024
@jbaudoux jbaudoux reopened this Sep 22, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants