-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][FIX] delivery_send_to_shipper_at_operation: Keep delivery_notification_sent set on backorder #782
base: 14.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we simply revert this #720 ?
No it is fine to not copy the value, because move_dest_ids/move_orig_ids will also not copied from a move. |
@mt-software-de I should have added a unittest for my fix #720. If you do a partial pack, then you don't want to keep |
For the pack operation backorder it is fine, to not set the
|
57f8c4b
to
fdb7424
Compare
78b5e82
to
116a601
Compare
116a601
to
7352e84
Compare
c8c52ec
to
ef147b5
Compare
Keep delivery_notification_sent set on backorder
ef147b5
to
88e2ca4
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
If a backorder is created out of a transfer which is marked as delivery_notification_sent = True.
The backorder should also be marked as delivery_notification_sent.
@jbaudoux @TDu
Depends on:
Fixing tests
#786