Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP]delivery_delivery_package_fee delivery_automatic_package delivery_package_number simplify tests #854

Open
wants to merge 3 commits into
base: 16.0
Choose a base branch
from

Conversation

hparfr
Copy link
Contributor

@hparfr hparfr commented Jul 9, 2024

Simplify tests by removing the now useless context key.

Includes:

Tests only pass if we have all the commit (this PR).

@hparfr hparfr force-pushed the 16.0-fix-base_delivery_label-automatic-pack-creation_simplify-test-in-other-modules branch from 5ecff2a to f54d349 Compare July 9, 2024 12:56
@hparfr hparfr force-pushed the 16.0-fix-base_delivery_label-automatic-pack-creation_simplify-test-in-other-modules branch from f54d349 to c0fff8b Compare July 9, 2024 13:25
Copy link
Contributor

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review

@mt-software-de
Copy link
Contributor

Thx. It would be great to move forward with this. I hunger for it :-)
What is about this 1984571
cc @rousseldenis @chienandalu

Copy link
Contributor

@mt-software-de mt-software-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Is it ok to break the current implementation of delivery_roulier?

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the delivery_package_number part. Thanks :)

because it's not anymore in base_delivery_carrier_label
because it's not anymore in base_delivery_carrier_label
because it's not anymore in base_delivery_carrier_label
@hparfr hparfr force-pushed the 16.0-fix-base_delivery_label-automatic-pack-creation_simplify-test-in-other-modules branch from c0fff8b to 556fdaa Compare September 23, 2024 07:21
@hparfr
Copy link
Contributor Author

hparfr commented Sep 23, 2024

Now that the depend pr is merged; this one is ready.
I have rebased on 16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants