[16.0] delivery_roulier: raise when no pack found and fix tests #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because, base_delivery_carrier_label do not create packs automatically anymore, we have to create a pack in delivery_roulier_tests Delivery roulier still can't work without pack. Also, add myself as a maintainer of the module.
|
Hi @florian-dacosta, |
|
Closing in favor of #853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because, base_delivery_carrier_label do not create packs automatically anymore, we have to create a pack in delivery_roulier_tests
Delivery roulier still can't work without pack.
Also, add myself as a maintainer of the module.
See also:
This PR is red because it needs #853
#853 is red because it needs this PR.
#854 contains #853 and #855
To be merged with
major