Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] l10n_br_account_withholding: add new module and extract/refactor features from l10n_br_account #3005

Merged
merged 3 commits into from
Apr 18, 2024
Merged

[14.0][ADD] l10n_br_account_withholding: add new module and extract/refactor features from l10n_br_account #3005

merged 3 commits into from
Apr 18, 2024

Conversation

marcelsavegnago
Copy link
Member

@marcelsavegnago marcelsavegnago commented Apr 9, 2024 •
edited
Loading

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @rvalyi, @renatonlima,
some modules you are maintaining are being modified, check this out!

@marcelsavegnago marcelsavegnago force-pushed the 14.0-l10n_br_account_tax_invoice_generator branch 10 times, most recently from 09a082c to 731dd33 Compare April 9, 2024 21:32
@marcelsavegnago marcelsavegnago changed the title [WIP][14.0] l10n_br_account_withholding: add new module and extract features from l10n_br_account [WIP][14.0] l10n_br_account_withholding: add new module and extract/refactor features from l10n_br_account Apr 9, 2024
@marcelsavegnago marcelsavegnago force-pushed the 14.0-l10n_br_account_tax_invoice_generator branch 3 times, most recently from 7484fce to 16fee06 Compare April 11, 2024 14:22
rvalyi
rvalyi previously requested changes Apr 11, 2024
View reviewed changes
l10n_br_account_withholding/demo/account_move.xml Outdated Show resolved Hide resolved
l10n_br_account_withholding/demo/l10n_br_fiscal_tax_group.xml Outdated Show resolved Hide resolved
@marcelsavegnago marcelsavegnago force-pushed the 14.0-l10n_br_account_tax_invoice_generator branch 6 times, most recently from 169b608 to fda08f6 Compare April 11, 2024 22:36
@marcelsavegnago marcelsavegnago mentioned this pull request Apr 11, 2024
Closed
@marcelsavegnago marcelsavegnago marked this pull request as ready for review April 11, 2024 22:53
@rvalyi rvalyi dismissed their stale review April 11, 2024 23:21

code updated

@marcelsavegnago marcelsavegnago force-pushed the 14.0-l10n_br_account_tax_invoice_generator branch from fda08f6 to cc02889 Compare April 12, 2024 11:00
@marcelsavegnago
Copy link
Member Author

eu so tirava o arquivo vazio l10n_br_account_withholding/readme/ROADMAP.md mas do restante ficou top!

Ou então poderia copiar no ROADMAP os itens que vc listou em #3005 (comment)

ROADMAP.rst removido

@rvalyi
Copy link
Member

rvalyi commented Apr 12, 2024

@marcelsavegnago vc conseguiria tb ajustar esse PR na 16 #3008 ? A gente ainda não fez o port disso. Ai so para não sobrar para gente nas camadas baixas já migradas seria legal...

@marcelsavegnago
Copy link
Member Author

@marcelsavegnago vc conseguiria tb ajustar esse PR na 16 #3008 ? A gente ainda não fez o port disso. Ai so para não sobrar para gente nas camadas baixas já migradas seria legal...

opa.. vou ajustar..

@marcelsavegnago marcelsavegnago force-pushed the 14.0-l10n_br_account_tax_invoice_generator branch 2 times, most recently from a5eb4ed to 480e88d Compare April 13, 2024 18:44
WesleyOliveira98
WesleyOliveira98 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelsavegnago marcelsavegnago force-pushed the 14.0-l10n_br_account_tax_invoice_generator branch from 480e88d to b49c3a8 Compare April 17, 2024 20:41
@marcelsavegnago marcelsavegnago force-pushed the 14.0-l10n_br_account_tax_invoice_generator branch from 48a967f to bbff897 Compare April 17, 2024 22:41
@marcelsavegnago marcelsavegnago force-pushed the 14.0-l10n_br_account_tax_invoice_generator branch from bbff897 to cfcf74c Compare April 18, 2024 12:05
@marcelsavegnago
Copy link
Member Author

@marcelsavegnago vc conseguiria tb ajustar esse PR na 16 #3008 ? A gente ainda não fez o port disso. Ai so para não sobrar para gente nas camadas baixas já migradas seria legal...

Done

@marcelsavegnago
Copy link
Member Author

Removendo este trecho da descrição da PR.. e deixando aqui como um comentário caso amanha precise resgatar alguma ideia daqui..

Uma possibilidade seria fazer um modulo generico para geração de faturas de impostos onde a primeira coisa a ser abordada são os impostos retidos onde são gerados uma fatura para cada linha contabil de imposto retido. Nesta caso precisaria fazer algumas mudanças:

  • Alterar o nome do modulo para algo como l10n_br_account_tax_invoice_generator
  • Alterar o nome das variaveis e metodos trocando o prefixo WH por TAX ou BRTAX ou algo do genero para nao conflitar com algo.
  • Podemos adicionar no grupo de imposto a periodicidade de apuração.
  • Alterar a variavel wh_move_line_id para many2many e permitir que a fatura do imposto esteja ligada a mais de uma linha de lancamento contabil daquele imposto
  • Criar jobs para para fazer a apuração e gerar as faturas do imposto
  • implementar algum controle para casos e que as faturas vinculadas a fatura do imposto sejam alteradas.

Obs. por ora o foco é tratar as faturas de impostos retidos mas pensando no futuro, o nome do modulo, nome dos campos e nome dos metodos mais genericos fique mais facil extender.. não sei..

rvalyi
rvalyi approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valeu pelo trabalho @marcelsavegnago

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rvalyi
Copy link
Member

rvalyi commented Apr 18, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-3005-by-rvalyi-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a963643 into OCA:14.0 Apr 18, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8c6a94d. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago marcelsavegnago deleted the 14.0-l10n_br_account_tax_invoice_generator branch April 18, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@WesleyOliveira98 WesleyOliveira98 WesleyOliveira98 approved these changes

@antoniospneto antoniospneto Awaiting requested review from antoniospneto

@mileo mileo Awaiting requested review from mileo

@douglascstd douglascstd Awaiting requested review from douglascstd

@renatonlima renatonlima Awaiting requested review from renatonlima

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcelsavegnago @OCA-git-bot @rvalyi @WesleyOliveira98