Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [RFC] l10n_br_coa: refactor withholding (port from #3001 and 3015) #3008

Merged

Conversation

marcelsavegnago
Copy link
Member

@marcelsavegnago marcelsavegnago commented Apr 9, 2024

Port from #3001 and #3015

@marcelsavegnago marcelsavegnago force-pushed the 16.0-rfc-l10n_br_coa-refactor-withholding branch 2 times, most recently from 4310bbd to 5349da3 Compare April 9, 2024 22:53
@marcelsavegnago marcelsavegnago marked this pull request as draft April 9, 2024 22:57
@marcelsavegnago marcelsavegnago force-pushed the 16.0-rfc-l10n_br_coa-refactor-withholding branch 2 times, most recently from 7d25965 to f5c78de Compare April 18, 2024 14:07
@marcelsavegnago marcelsavegnago marked this pull request as ready for review April 18, 2024 14:16
@marcelsavegnago marcelsavegnago force-pushed the 16.0-rfc-l10n_br_coa-refactor-withholding branch from f5c78de to 0a0e410 Compare April 18, 2024 16:01
@marcelsavegnago marcelsavegnago changed the title [16.0] [RFC] l10n_br_coa: refactor withholding (port from #3001) [16.0] [RFC] l10n_br_coa: refactor withholding (port from #3001 and 3015) Apr 18, 2024
@marcelsavegnago marcelsavegnago force-pushed the 16.0-rfc-l10n_br_coa-refactor-withholding branch from 0a0e410 to 673ff6e Compare April 18, 2024 16:18
@marcelsavegnago marcelsavegnago force-pushed the 16.0-rfc-l10n_br_coa-refactor-withholding branch from 673ff6e to a34ecdd Compare April 18, 2024 16:23
Copy link
Contributor

@augustodinizl augustodinizl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelsavegnago
Copy link
Member Author

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3008-by-marcelsavegnago-bump-major, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit cc064f0 into OCA:16.0 Apr 18, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 498690e. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago marcelsavegnago deleted the 16.0-rfc-l10n_br_coa-refactor-withholding branch April 18, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants