Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] l10n_it_ateco #2978

Closed
wants to merge 30 commits into from
Closed

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Oct 21, 2022

Migration l10n_it_ateco from 14.0 to 16.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@Borruso Borruso force-pushed the 16.0-mig-l10n_it_ateco branch 2 times, most recently from 2b485bb to e5e540e Compare October 24, 2022 07:21

_inherit = "res.partner"

ateco_category_ids = fields.Many2many(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao, in base alla discussione in call, i campi andrebbero rinominati col prefisso l10n_it_ come fa Odoo.


class AtecoCategory(models.Model):

_name = "ateco.category"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non so per quanto riguarda i nomi dei modelli, però anche qui farei l10n_it_ateco.category.

@Borruso Borruso force-pushed the 16.0-mig-l10n_it_ateco branch 4 times, most recently from f39f2c8 to cf836f8 Compare October 28, 2022 09:20
@TheMule71 TheMule71 mentioned this pull request Nov 1, 2022
79 tasks
@primes2h
Copy link
Contributor

primes2h commented Nov 8, 2022

/ocabot migration l10n_it_ateco

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 8, 2022
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_ateco branch from cf836f8 to 6991e84 Compare November 10, 2022 10:37
@Borruso Borruso marked this pull request as ready for review November 10, 2022 10:37
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_ateco branch from 6991e84 to a32b3ad Compare November 10, 2022 10:46
Copy link

@warp10 warp10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Borruso Borruso force-pushed the 16.0-mig-l10n_it_ateco branch from a32b3ad to 1603a45 Compare November 11, 2022 08:58
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_ateco branch from 1603a45 to 0efd917 Compare November 11, 2022 09:08
@eLBati
Copy link
Member

eLBati commented Nov 11, 2022

A proposito di #2978 (review) abbiamo detto che per ora teniamo i nomi correnti

Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash administrative commits (if any) with the previous commit for reducing commit noise.
Puoi eventualmente fare riferimento a https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

@tafaRU
Copy link
Member

tafaRU commented Nov 11, 2022

Risolto #2978 (review) in #3035

@tafaRU tafaRU closed this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.