Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] l10n_it_bill_of_entry: Gestione del multi-azienda nei test #4193

Conversation

SirAionTech
Copy link
Contributor

Corregge #4192 per 16.0.

Copy link
Contributor

@matteoopenf matteoopenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SirAionTech SirAionTech marked this pull request as draft June 5, 2024 15:19
The user must be logged in only one company for the tests to behave as expected.
For instance, searching for a journal should only find journals in the current company
@SirAionTech SirAionTech force-pushed the 16.0-cov-l10n_it_bill_of_entry-multi_company_management branch from b1bf5de to 4ac648c Compare June 5, 2024 15:28
@SirAionTech SirAionTech marked this pull request as ready for review June 5, 2024 15:55
@SirAionTech SirAionTech requested a review from matteoopenf June 5, 2024 15:55
Copy link
Contributor

@PicchiSeba PicchiSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@matteoopenf se riapprovi mergiamo

@francesco-ooops
Copy link
Contributor

@OCA/local-italy-maintainers merge?

@eLBati
Copy link
Member

eLBati commented Jun 17, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-4193-by-eLBati-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fe67d0d into OCA:16.0 Jun 17, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5c160b1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

l10n_it_bill_of_entry: Gestione del multi-azienda nei test
6 participants