[MIG]11.0 mig l10n nl partner salutation #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daramousk
force-pushed
the
11.0-mig-l10n_nl_partner_salutation
branch
from
7e5b19a to
2b22557
Compare
daramousk
force-pushed
the
11.0-mig-l10n_nl_partner_salutation
branch
2 times, most recently
from
55b2714 to
b538640
Compare
daramousk
changed the title
daramousk
force-pushed
the
11.0-mig-l10n_nl_partner_salutation
branch
from
b538640 to
23c9c89
Compare
daramousk
force-pushed
the
11.0-mig-l10n_nl_partner_salutation
branch
from
23c9c89 to
de098d4
Compare
NL66278
reviewed
Jan 21, 2019
NL66278
reviewed
Jan 21, 2019
NL66278
reviewed
Jan 21, 2019
| @@ -0,0 +1,2 @@ | |||
| from . import res_partner_title | |||
NL66278
reviewed
Jan 21, 2019
NL66278
approved these changes
Jan 21, 2019
|
Failures are due to OCA/partner-contact#660 (review) not yet merged. |
daramousk
force-pushed
the
11.0-mig-l10n_nl_partner_salutation
branch
from
de098d4 to
ce93230
Compare
|
@lfreeke And here |
|
@daramousk please rebase on current 11.0 |
daramousk
force-pushed
the
11.0-mig-l10n_nl_partner_salutation
branch
from
ce93230 to
63cef15
Compare
daramousk
force-pushed
the
11.0-mig-l10n_nl_partner_salutation
branch
from
63cef15 to
7cead91
Compare
- Do not add gender field in this module, but rely on partner_contact_gender. - Use standard directories. - Make sure tests use same name formatting as in model. - make test class and method name confirm to actual tests done. - Properly handle is_company partners. - Make a difference between unknown gender and other gender.
+ Standard copyright headers + Migration of 'unknown' gender value to NULL.
daramousk
force-pushed
the
11.0-mig-l10n_nl_partner_salutation
branch
from
b68a175 to
952da76
Compare
|
Hello @sbidoul , |
|
Closing and reopening to force runbot |
|
He Guys, |
|
Close and open again. To rerun runbot. |
hbrunn
approved these changes
Jul 29, 2020
|
/ocabot merge major |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 7d6ec52. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.