[MIG] 11.0 mig partner company type #660
Conversation
|
Hey @daramousk, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
partner_company_type/__manifest__.py
Outdated
| 'version': '11.0.1.0.0', | ||
| 'license': 'AGPL-3', | ||
| 'author': 'ACSONE SA/NV,Odoo Community Association (OCA)', | ||
| 'website': 'https://acsone.eu', |
There was a problem hiding this comment.
@daramousk website should be this
| @@ -0,0 +1,5 @@ | |||
| # Copyright 2014-2015 Grupo ESOC <www.grupoesoc.es> | |||
There was a problem hiding this comment.
@daramousk remove Copyright from all __init__ file
| """Partner with birth date in date format.""" | ||
| _inherit = "res.partner" | ||
|
|
||
| birthdate_date = fields.Date("Birthdate") |
There was a problem hiding this comment.
IMO here change birthdate_date to birthdate. For more worth reading.
Currently translated at 100,0% (15 of 15 strings) Translation: partner-contact-10.0/partner-contact-10.0-partner_company_type Translate-URL: https://translation.odoo-community.org/projects/partner-contact-10-0/partner-contact-10-0-partner_company_type/pt_BR/
daramousk
force-pushed
the
11.0-mig-partner_company_type
branch
2 times, most recently
from
8437d6c to
f81c62e
Compare
|
@hbrunn The tests do not actually fail but they are marked as a failure. See assertRaises. Also, I am not sure what to do with the CLA not being signed. |
|
wrap it in https://github.com/OCA/OCB/blob/11.0/odoo/tools/misc.py#L783 The mail address is @yajo, so no problem. Do we have a possibility to declare aliases of people for the CLA bot? |
|
Uhm, that's a problem... He worked for other company and makes with that email address the commits, but no he works for us and uses other email address, but the GitHub login is still the same... @yajo, do you still have the other email address registered here in GitHub? |
|
I think the alias makes sense. @StefanRijnhart had changed commit addresses too, don't you run in the same problem? |
|
I did not mix addresses so I did not have this problem.
|
|
but why does it work when I pull stuff that |
|
Seems like Github adds the login in the commit metadata https://github.com/gurneyalex/ak-oca-clabot/blob/master/clabot.py#L371 |
|
interesting, cool and a little bit scary wanting to look through the metadata in our source trees |
|
Pedro found an instance of this error with my old email though: OCA/account-financial-tools#738 (comment) |
|
I do not own that old address anymore, but my CLA is OK. I think we can just ignore the CLA message. |
daramousk
force-pushed
the
11.0-mig-partner_company_type
branch
from
f81c62e to
6ed0116
Compare
| @@ -0,0 +1 @@ | |||
| from . import models | |||
There was a problem hiding this comment.
init.py files still by convention have the License line, only the copyright lines were dropped
|
@daramousk Hi George, are you going to take up the review comments on this one? |
|
@daramousk And it helps if you remove the WIP. |
daramousk
force-pushed
the
11.0-mig-partner_company_type
branch
from
98b21eb to
f16a826
Compare
daramousk
changed the title
|
@lfreeke Need your approval here as well |
|
@daramousk Travis 🔴 |
|
Travis error is in base_location_nuts. Nothing to do with this PR. |
|
Another example of why unit tests should not depend on the availability of external services... |
|
@NL66278 if you merge a migration PR, please remember to check the mark in the migration issue for marking the module migration as completed. I have already done it for the modules you have merged today. |
|
@pedrobaeza Thanks. I will try to remember it. |
No description provided.