Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [ADD] l10n_ch_adr_report #670

Closed
wants to merge 5 commits into from

Conversation

sonhd91
Copy link

@sonhd91 sonhd91 commented Sep 5, 2022

Depended on:

@sonhd91 sonhd91 marked this pull request as draft September 5, 2022 10:03
sonhd added 2 commits September 5, 2022 17:08
l10n_eu_product_adr_dangerous_goods -> l10n_eu_product_adr_dangerous_good
Copy link
Contributor

@hailangvn hailangvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

"license": "AGPL-3",
"application": False,
"installable": True,
"depends": ["l10n_eu_product_adr_dangerous_good", "stock", "delivery"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"depends": ["l10n_eu_product_adr_dangerous_good", "stock", "delivery"],
"depends": ["l10n_eu_product_adr_dangerous_goods", "stock", "delivery"],

I changed back the name to l10n_eu_product_adr_dangerous_goods.
See this comment OCA/stock-logistics-workflow#937 (comment)

@TDu
Copy link
Member

TDu commented Oct 12, 2022

This is superseded by #674

@TDu TDu closed this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants