Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] stock_dangerous_goods #937

Merged
merged 2 commits into from
Feb 16, 2023
Merged

[14.0][MIG] stock_dangerous_goods #937

merged 2 commits into from
Feb 16, 2023

Conversation

mmequignon
Copy link
Member

@mmequignon mmequignon commented Dec 2, 2021 •
edited
Loading

@mmequignon mmequignon force-pushed the 14.0-mig-stock_dangerous_goods branch 2 times, most recently from 4cd8dd5 to 9d551a9 Compare December 3, 2021 10:14
@sebalix sebalix added this to the 14.0 milestone Dec 3, 2021
@sebalix sebalix changed the title [WIP] 14.0 mig stock dangerous goods [14.0][MIG] stock_dangerous_goods Dec 3, 2021
sebalix
sebalix reviewed Dec 3, 2021
View reviewed changes
test-requirements.txt Outdated Show resolved Hide resolved
@sebalix sebalix mentioned this pull request Dec 8, 2021
Merged
@mmequignon mmequignon force-pushed the 14.0-mig-stock_dangerous_goods branch from 9d551a9 to 7e010a6 Compare December 8, 2021 10:14
@sebalix
Copy link
Contributor

sebalix commented Dec 20, 2021

/ocabot migration stock_dangerous_goods

@OCA-git-bot OCA-git-bot mentioned this pull request Dec 20, 2021
Open
57 tasks
@simahawk simahawk mentioned this pull request Jul 28, 2022
Merged
@simahawk
Copy link
Contributor

Base PR is getting merged 🎉

@pedrobaeza
Copy link
Member

Please avoid plurals on module name.

@sebalix sebalix marked this pull request as ready for review August 29, 2022 09:02
@simahawk simahawk mentioned this pull request Aug 29, 2022
Merged
@sonhd91 sonhd91 mentioned this pull request Sep 5, 2022
Closed
@rousseldenis
Copy link
Contributor

Please avoid plurals on module name.

@pedrobaeza @mmequignon Can stay as is as 'goods' is unvariable and don't exist at singular form

@pedrobaeza
Copy link
Member

Ok, didn't know

@mmequignon
Copy link
Member Author

Please avoid plurals on module name.

@pedrobaeza @mmequignon Can stay as is as 'goods' is unvariable and don't exist at singular form

Actually, it looks like "goods" is the plural of "good"
https://dictionary.cambridge.org/fr/dictionnaire/anglais/goods
https://dictionary.cambridge.org/fr/dictionnaire/anglais/good

@rousseldenis
Copy link
Contributor

Please avoid plurals on module name.

@pedrobaeza @mmequignon Can stay as is as 'goods' is unvariable and don't exist at singular form

Actually, it looks like "goods" is the plural of "good"
https://dictionary.cambridge.org/fr/dictionnaire/anglais/goods
https://dictionary.cambridge.org/fr/dictionnaire/anglais/good

Hehe didn't know too. Never used it like that

@mmequignon
Copy link
Member Author

Please avoid plurals on module name.

@pedrobaeza @mmequignon Can stay as is as 'goods' is unvariable and don't exist at singular form

Actually, it looks like "goods" is the plural of "good"
https://dictionary.cambridge.org/fr/dictionnaire/anglais/goods
https://dictionary.cambridge.org/fr/dictionnaire/anglais/good

Hehe didn't know too. Never used it like that

Yeah, I wasn't sure. I've discussed about this with @gurneyalex .
It looks like dangerous good is an alignment in dungeons and dragons.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 12, 2023
@bosd
Copy link
Contributor

bosd commented Feb 16, 2023

Now the other 2 have merged. This one is next??

@rousseldenis
Copy link
Contributor

@mmequignon Still WIP or ready?

@mmequignon
Copy link
Member Author

@mmequignon Still WIP or ready?

just rebased, this is ready :)

rousseldenis
rousseldenis approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

stock_dangerous_goods/models/product_product.py
class ProductProduct(models.Model):
_inherit = "product.product"

is_lq_product = fields.Boolean(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer explicit names than abbreviations. But nitpicking

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could consider this for v16

@simahawk
Copy link
Contributor

/ocabot merge nobump

@simahawk simahawk removed work in progress stale PR/Issue without recent activity, it'll be soon closed automatically. labels Feb 16, 2023
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-937-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9e79a89 into OCA:14.0 Feb 16, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 15f37e7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix left review comments

@simahawk simahawk simahawk approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mmequignon @sebalix @simahawk @pedrobaeza @rousseldenis @bosd @OCA-git-bot