Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] pylint-odoo: usable under python 3.10 #128

Merged
merged 1 commit into from
Mar 29, 2022
Merged

[FIX] pylint-odoo: usable under python 3.10 #128

merged 1 commit into from
Mar 29, 2022

Conversation

yajo
Copy link
Member

@yajo yajo commented Mar 7, 2022

Fixes #127

@yajo yajo requested review from Tardo, moylop260 and sbidoul March 7, 2022 08:32
@yajo yajo self-assigned this Mar 7, 2022
@yajo yajo added the bug Something isn't working label Mar 7, 2022
moylop260
moylop260 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@moylop260 moylop260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tardo
Copy link
Member

Tardo commented Mar 15, 2022

👍 Tested. Thanks!

@OCA-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain legalsylvain mentioned this pull request Mar 18, 2022
Merged
@sbidoul
Copy link
Member

sbidoul commented Mar 18, 2022 •
edited
Loading

If we do this, can we / should we remove the python version pinning here ?

@yajo
Copy link
Member Author

yajo commented Mar 21, 2022

So it seems.

@yajo
Copy link
Member Author

yajo commented Mar 21, 2022

Fixed now.

@pedrobaeza pedrobaeza merged commit c560532 into OCA:master Mar 29, 2022
@sbidoul sbidoul mentioned this pull request Apr 3, 2022
Merged
@yajo yajo deleted the fix-pylint-for-py310 branch April 6, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moylop260 moylop260 moylop260 approved these changes

@Tardo Tardo Tardo approved these changes

@sbidoul sbidoul Awaiting requested review from sbidoul

Assignees

@yajo yajo

Labels
approved bug Something isn't working ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin python version to 3.9 or update dependencies to work with 3.10+?
6 participants
@yajo @Tardo @OCA-git-bot @sbidoul @moylop260 @pedrobaeza