Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] pylint-odoo: usable under python 3.10 #128

Merged
merged 1 commit into from
Mar 29, 2022
Merged

[FIX] pylint-odoo: usable under python 3.10 #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/.github/workflows/pre-commit.yml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,6 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
with:
# The pylint-odoo version we use here does not support python 3.10
# https://github.com/OCA/oca-addons-repo-template/issues/80
# We also need to pin to an older version of python for older odoo versions
# where we are not using black > 21. Older black versions won't work with
# Python 3.9.8+, and we can't bump black without reformatting.
python-version: {% if odoo_version < 15 %}"3.9.7"{% else %}"3.10"{% endif %}
- name: Get python version
run: echo "PY=$(python -VV | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
- uses: actions/cache@v1
Expand Down
7 changes: 3 additions & 4 deletions src/.pre-commit-config.yaml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@
{%- set repo_rev.pre_commit_hooks = "v3.2.0" %}
{%- set repo_rev.prettier = "2.1.2" %}
{%- set repo_rev.prettier_xml = "0.12.0" %}
{#- HACK https://github.com/OCA/pylint-odoo/issues/296#issuecomment-700317722 #}
{%- set repo_rev.pylint = "pylint-2.5.3" %}
{%- set repo_rev.pylint_odoo = "3.5.0" %}
{%- set repo_rev.pylint = "v2.11.1" %}
{%- set repo_rev.pylint_odoo = "5.0.5" %}
{%- set repo_rev.pyupgrade = "v2.7.2" %}
{%- set repo_rev.setuptools_odoo = "2.6.0" %}
{%- else %}
Expand All @@ -31,7 +30,7 @@
{%- set repo_rev.prettier = "2.4.1" %}
{%- set repo_rev.prettier_xml = "1.1.0" %}
{%- set repo_rev.pylint = "v2.11.1" %}
{%- set repo_rev.pylint_odoo = "5.0.4" %}
{%- set repo_rev.pylint_odoo = "5.0.5" %}
{%- set repo_rev.pyupgrade = "v2.29.0" %}
{%- set repo_rev.setuptools_odoo = "3.0.3" %}
{%- endif %}
Expand Down