Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][IMP]product_attribute_set: Improve write on category #125

Merged
merged 2 commits into from
May 10, 2023
Merged

[13.0][IMP]product_attribute_set: Improve write on category #125

merged 2 commits into from
May 10, 2023

Conversation

GuillemCForgeFlow
Copy link
Contributor

Adds the option of writing on many categories at the same time.
cc @ForgeFlow

@GuillemCForgeFlow GuillemCForgeFlow changed the title [IMP]product_attribute_set: Improve write on category [13.0][IMP]product_attribute_set: Improve write on category Nov 16, 2022
JordiMForgeFlow
JordiMForgeFlow approved these changes Nov 16, 2022
View reviewed changes
Copy link

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 , not sure why precommit fails, seems to be something with the configuration. Maybe

odoo-pim/.pre-commit-config.yaml

Line 108 in 25b1276

- repo: https://gitlab.com/pycqa/flake8

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 13.0-imp-product_attribute_set-imp_write branch from 0230046 to 65b17f5 Compare November 16, 2022 13:18
DavidJForgeFlow
DavidJForgeFlow approved these changes Nov 16, 2022
View reviewed changes
Copy link

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍 Code also LGTM!

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 13.0-imp-product_attribute_set-imp_write branch from 65b17f5 to 9b9e96d Compare November 16, 2022 15:40
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 2, 2023
@github-actions github-actions bot closed this May 7, 2023
@GuillemCForgeFlow
Copy link
Contributor Author

Hi @rousseldenis can we reopen this and get it merged? It's a minor improvement 😄

@rousseldenis rousseldenis reopened this May 8, 2023
rousseldenis
rousseldenis approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great. It should be great to add tests in this module.

@GuillemCForgeFlow
Copy link
Contributor Author

Seems great. It should be great to add tests in this module.

Sure, I'll add them and let you know when it is ready to merge !

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 13.0-imp-product_attribute_set-imp_write branch from 9b9e96d to 03e40ea Compare May 8, 2023 08:48
@GuillemCForgeFlow
Copy link
Contributor Author

Seems great. It should be great to add tests in this module.

Sure, I'll add them and let you know when it is ready to merge !

@rousseldenis done! 👍🏽

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

@GuillemCForgeFlow Have you seen that this has been adressed differently in v14 ?

https://github.com/OCA/odoo-pim/blob/14.0/product_attribute_set/models/product_category.py

@PierrickBrun

@GuillemCForgeFlow
Copy link
Contributor Author

@GuillemCForgeFlow Have you seen that this has been adressed differently in v14 ?

https://github.com/OCA/odoo-pim/blob/14.0/product_attribute_set/models/product_category.py

@PierrickBrun

I see, but what I'm improving here also is writing on multiple products with one call (not done in v14). Not only the fact that the write method accepts a multi-record call.

If you both agree, maybe we should merge this and forward port these changes to the following versions.

WDYT?
@rousseldenis @PierrickBrun

@PierrickBrun
Copy link
Contributor

If you both agree, maybe we should merge this and forward port these changes to the following versions.

WDYT? @rousseldenis @PierrickBrun

It looks like the ideal solution, indeed

@rousseldenis
Copy link
Contributor

/ocabot merge minor

@rousseldenis
Copy link
Contributor

@GuillemCForgeFlow You take care of forwardports ?

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-125-by-rousseldenis-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 02fa1e1 into OCA:13.0 May 10, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8616b9a. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 13.0-imp-product_attribute_set-imp_write branch May 10, 2023 08:30
@GuillemCForgeFlow
Copy link
Contributor Author

@GuillemCForgeFlow You take care of forwardports ?

Sure!

This was referenced May 10, 2023
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidJForgeFlow DavidJForgeFlow DavidJForgeFlow approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@GuillemCForgeFlow @OCA-git-bot @rousseldenis @PierrickBrun @MiquelRForgeFlow @JordiMForgeFlow @DavidJForgeFlow