[16.0][MIG] product_attribute_set #142

sbejaoui · 2023-02-28T11:11:22Z

No description provided.

lmignon

Thank you @sbejaoui LGTM (Code review + functional tests)

GuillemCForgeFlow · 2023-05-10T10:55:46Z

Hi @sbejaoui, I've added some improvements here: #125. Could you also add them here?
Thank you 😄

Camille0907

Migration LGTM

product_attribute_set/__manifest__.py

product_attribute_set/models/product.py

simahawk · 2023-08-09T13:08:47Z

product_attribute_set/models/product.py

+            self.attribute_set_id = self.categ_id.attribute_set_id
+
+
+# TODO : add the 'attribute.set.owner.mixin' to product.product in order to display


TODO still valid?

product_attribute_set/models/product_category.py

simahawk · 2023-08-09T13:11:57Z

@sbejaoui just a reminder: - in the commit msg are not needed 😉

simahawk · 2023-08-09T13:14:06Z

/ocabot migration product_attribute_set

victorvermot · 2023-08-15T07:33:24Z

@sbejaoui Could you attend to simahawk's comments and rebase PR ? Ty in advance

test-requirements.txt

simahawk

LG overall. Cleaning up commits as per #141 would be nice ;)

simahawk · 2023-08-21T13:40:54Z

product_attribute_set/models/product.py

+            self.attribute_set_id = self.categ_id.attribute_set_id
+
+
+# TODO : add the 'attribute.set.owner.mixin' to product.product in order to display


simahawk · 2023-08-21T13:41:40Z

product_attribute_set/models/product_category.py

+        # Fill Category's products with Category's default attribute_set_id if empty
+        super().write(vals)
+        for record in self:
+            if vals.get("attribute_set_id"):


can we have any test here?

rousseldenis · 2023-10-24T07:09:37Z

I've added a dependency on #171 to remove domain from view (as it causes access rights problems for normal users)

New organization : - attribute_set (former base_custom_attribute) - product_attribute_set (former pim_custom_attribute but without menus) - pim (The "PIM application" former pim_base) - pim_attrubute_set (depends on product_attribute_set and adds menus in the PIM application)

And small FIX in _build_attribute_field()

[UPD] README.rst

[UPD] README.rst [UPD] README.rst [ADD] icon.png

courtesy of <olivier@naya-tec.com> Apply dotfiles [UPD] Update product_attribute_set.pot

[UPD] README.rst

[UPD] Update product_attribute_set.pot

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: odoo-pim-14.0/odoo-pim-14.0-product_attribute_set Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-14-0/odoo-pim-14-0-product_attribute_set/

Currently translated at 100.0% (27 of 27 strings) Translation: odoo-pim-14.0/odoo-pim-14.0-product_attribute_set Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-14-0/odoo-pim-14-0-product_attribute_set/es_AR/

See OCA#171

lmignon · 2023-11-20T16:00:52Z

@rousseldenis #171 is merged.. This one is ready to be merged

simahawk · 2023-11-20T16:58:03Z

/ocabot merge minor

OCA-git-bot · 2023-11-20T16:58:26Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-142-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot · 2023-11-20T17:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2023-11-20T17:02:10Z

Congratulations, your PR was merged at e8446f8. Thanks a lot for contributing to OCA. ❤️

sbejaoui force-pushed the 16.0-product_attribute_set-sbj branch 2 times, most recently from ddc4f56 to d50bd05 Compare February 28, 2023 14:06

lmignon approved these changes Mar 3, 2023

View reviewed changes

StevenSermeus mentioned this pull request Apr 18, 2023

[16.0][ADD] - product attribute json #147

Closed

This was referenced Jul 20, 2023

[16.0][mig] pim: Migration to 16.0 #165

Closed

[16.0][mig] product_attribute_set_completeness: Migration to 16.0 #164

Closed

Camille0907 approved these changes Aug 8, 2023

View reviewed changes

simahawk reviewed Aug 9, 2023

View reviewed changes

OCA-git-bot added this to the 16.0 milestone Aug 9, 2023

OCA-git-bot mentioned this pull request Aug 9, 2023

Migration to version 16.0 #123

Open

3 tasks

simahawk mentioned this pull request Aug 9, 2023

[16.0][mig] attribute_set_completeness: Migration to 16.0 #162

Closed

sbejaoui force-pushed the 16.0-product_attribute_set-sbj branch from ec39862 to a061c05 Compare August 15, 2023 12:15

sbejaoui requested a review from simahawk August 15, 2023 12:37

santostelmo reviewed Aug 21, 2023

View reviewed changes

test-requirements.txt Outdated Show resolved Hide resolved

sbejaoui force-pushed the 16.0-product_attribute_set-sbj branch from 2ff4c3e to 9333148 Compare August 21, 2023 10:46

simahawk approved these changes Aug 21, 2023

View reviewed changes

OCA-git-bot added approved labels Aug 21, 2023

lmignon mentioned this pull request Nov 14, 2023

[16.0][MIG] shopinvader_product_attribute_set shopinvader/odoo-shopinvader#1450

Closed

2 tasks

clementmbr added 6 commits November 20, 2023 16:59

[REF] rename 'attribute_nature' field into 'nature'

266987e

And small FIX in _build_attribute_field()

[IMP] Add REAME to the 4 modules

a5c1355

[IMP] Move Product's attributes_placeholder to product_attribute_set

1a233a5

[IMP] remove class in super() and other misc improvements

35bf2d6

[FIX] remove tests in product_attribute_set

a9525ff

rousseldenis and others added 18 commits November 20, 2023 16:59

[13.0][MIG] product_attribute_set

e846f07

[UPD] README.rst

[MIG] make all modules uninstallable

ebbb071

[MIG] update pre-commit conf from copier

2a3c769

[IMP] product_attribute_set: black, isort, prettier

a5266f7

[MIG] product_attribute_set: Migration to 14.0

cd74163

[UPD] README.rst [UPD] README.rst [ADD] icon.png

[FIX] product_category multiple write

1667e88

courtesy of <olivier@naya-tec.com> Apply dotfiles [UPD] Update product_attribute_set.pot

product_attribute_set 14.0.1.0.1

4289b5d

[UPD] README.rst

Added translation using Weblate (Spanish)

3b02409

[UPD] Update product_attribute_set.pot

Update translation files

f8caa25

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: odoo-pim-14.0/odoo-pim-14.0-product_attribute_set Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-14-0/odoo-pim-14-0-product_attribute_set/

product_attribute_set 14.0.1.0.2

a234aab

Added translation using Weblate (Spanish (Argentina))

4350bca

Translated using Weblate (Spanish (Argentina))

a1ffea3

Currently translated at 100.0% (27 of 27 strings) Translation: odoo-pim-14.0/odoo-pim-14.0-product_attribute_set Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-14-0/odoo-pim-14-0-product_attribute_set/es_AR/

[IMP] product_attribute_set: black, isort, prettier

f03b34b

[16.0][MIG] - product_attribute_set

d28e5aa

[16.0][MIG] - product_attribute_set: add trnaslation fr_BE

f30191a

[16.0][MIG] - product_attribute_set: improve product view

59aebe6

[IMP] improve code

45101c1

[IMP] product_attribute_set: Remove domain as computed in attribute_set

1072cc5

See OCA#171

lmignon force-pushed the 16.0-product_attribute_set-sbj branch from 49f623f to 1072cc5 Compare November 20, 2023 15:59

simahawk changed the title ~~[16.0][MIG] - product_attribute_set~~ [16.0][MIG] product_attribute_set Nov 20, 2023

OCA-git-bot added bot is merging ⏳ ready to merge labels Nov 20, 2023

OCA-git-bot merged commit eb40176 into OCA:16.0 Nov 20, 2023
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] product_attribute_set #142

[16.0][MIG] product_attribute_set #142

sbejaoui commented Feb 28, 2023 •

edited

Loading

lmignon left a comment

GuillemCForgeFlow commented May 10, 2023 •

edited

Loading

Camille0907 left a comment •

edited

Loading

simahawk Aug 9, 2023

simahawk Aug 21, 2023

simahawk commented Aug 9, 2023

simahawk commented Aug 9, 2023

victorvermot commented Aug 15, 2023

simahawk left a comment

simahawk Aug 21, 2023

simahawk Aug 21, 2023

rousseldenis commented Oct 24, 2023

lmignon commented Nov 20, 2023

simahawk commented Nov 20, 2023

OCA-git-bot commented Nov 20, 2023

OCA-git-bot commented Nov 20, 2023

OCA-git-bot commented Nov 20, 2023

		self.attribute_set_id = self.categ_id.attribute_set_id


		# TODO : add the 'attribute.set.owner.mixin' to product.product in order to display

[16.0][MIG] product_attribute_set #142

[16.0][MIG] product_attribute_set #142

Conversation

sbejaoui commented Feb 28, 2023 • edited Loading

lmignon left a comment

Choose a reason for hiding this comment

GuillemCForgeFlow commented May 10, 2023 • edited Loading

Camille0907 left a comment • edited Loading

Choose a reason for hiding this comment

simahawk Aug 9, 2023

Choose a reason for hiding this comment

simahawk Aug 21, 2023

Choose a reason for hiding this comment

simahawk commented Aug 9, 2023

simahawk commented Aug 9, 2023

victorvermot commented Aug 15, 2023

simahawk left a comment

Choose a reason for hiding this comment

simahawk Aug 21, 2023

Choose a reason for hiding this comment

simahawk Aug 21, 2023

Choose a reason for hiding this comment

rousseldenis commented Oct 24, 2023

lmignon commented Nov 20, 2023

simahawk commented Nov 20, 2023

OCA-git-bot commented Nov 20, 2023

OCA-git-bot commented Nov 20, 2023

OCA-git-bot commented Nov 20, 2023

sbejaoui commented Feb 28, 2023 •

edited

Loading

GuillemCForgeFlow commented May 10, 2023 •

edited

Loading

Camille0907 left a comment •

edited

Loading