[16.0][IMP] attribute_set: Several improvements #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss data (tree/search...) Use get_view() to get the view_type directly. Moreover, this will allow to test it through odoo.tests.Form(). Add attribute_set_id field in test form (as it should be included in inherited views
If user is not in the base.group_erp_manager group, the value_ref field selection function will be computed without access rights on ir.model. So, hide the field for users not in that group.
Add all the attributes defined for the model into the list of fields to load to display the form view. Wihout this change a JS error occurs when displaying the form view of a x2many field for a model defining attributes. The origin of the error comes from the the get_views method which is called for the type 'form' only. In this case it's important to add all the custom attributes to the list of fields defined on the model for the view. When the same method is called without restriction it will load all the views. Since odoo include all the fields defined on the model for the search view, the error doesn't occur when using the form view from a menu action.
As model_id is referring to non accessible models for common users, set a related field in order to be able to use it in views domains. Moreover, add a domain on attribute_set_id field in attribute owner mixin in order to simplify inherited views.
rousseldenis
added a commit
to acsone/odoo-pim
that referenced
this pull request
Oct 24, 2023
As attribute view building is accessing ir.model records, do it with sudo.
rousseldenis
force-pushed
the
16.0-fix-rights-dro
branch
from
3d67b80 to
888f866
Compare
lmignon
approved these changes
Nov 14, 2023
2 tasks
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
This PR has the |
|
Congratulations, your PR was merged at fc3988f. Thanks a lot for contributing to OCA. ❤️ |
lmignon
pushed a commit
to acsone/odoo-pim
that referenced
this pull request
Nov 20, 2023
Vandan-OSI
pushed a commit
to ursais/odoo-pim
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes commits of #170
Some fixes about access errors for normal users (without erp manager group). See commit messages for details.