[17.0][MIG] attribute_set: Migration to 17.0 #190
Conversation
New organization : - attribute_set (former base_custom_attribute) - product_attribute_set (former pim_custom_attribute but without menus) - pim (The "PIM application" former pim_base) - pim_attrubute_set (depends on product_attribute_set and adds menus in the PIM application)
And small FIX in _build_attribute_field()
[UPD] README.rst [UPD] README.rst
[UPD] README.rst
…d attribute_set [CHG] add required columns on attributes on attribute set form view attribute_set 13.0.1.0.1
[UPD] README.rst [UPD] README.rst [ADD] icon.png Apply dotfiles [UPD] Update attribute_set.pot attribute_set 14.0.1.0.1 [UPD] README.rst [IMP] update dotfiles [ci skip]
[UPD] Update attribute_set.pot attribute_set 14.0.1.1.0
[UPD] Update attribute_set.pot [UPD] README.rst
When you define an attribute as a select field and add a related model, you have the option to "Load attribute options". On this wizard, an "option_ids" dummy field is created via fields_view_get. This change deletes option_ids from create (once the options are created) and read
menu items are visible only for two levels
[UPD] Update attribute_set.pot [UPD] README.rst [UPD] README.rst
…ss data (tree/search...) Use get_view() to get the view_type directly. Moreover, this will allow to test it through odoo.tests.Form(). Add attribute_set_id field in test form (as it should be included in inherited views
If user is not in the base.group_erp_manager group, the value_ref field selection function will be computed without access rights on ir.model. So, hide the field for users not in that group.
Add all the attributes defined for the model into the list of fields to load to display the form view. Wihout this change a JS error occurs when displaying the form view of a x2many field for a model defining attributes. The origin of the error comes from the the get_views method which is called for the type 'form' only. In this case it's important to add all the custom attributes to the list of fields defined on the model for the view. When the same method is called without restriction it will load all the views. Since odoo include all the fields defined on the model for the search view, the error doesn't occur when using the form view from a menu action.
dnplkndll
changed the title
|
@rousseldenis |
|
This PR has the |
@kobros-tech as I see you seem to be a serious contributor, I put the PR as draft to prevent an accidental merge as you requested it. Please explain us why it should not be merged yet. cc @dnplkndll I let you comment eventually, I didn't analyse the PR, but I'm amongst the persons at the origin of the module and @kobros-tech might have some good reason for not merging it yet, so let's see that... |
yes, thanks I have just wrote an issue on that and made a fix PR, can you review the PR and merge it in 14.0? |
kobros-tech
force-pushed
the
17.0-mig-attribute_set
branch
2 times, most recently
from
78bfaed to
6dba74d
Compare
|
Template design fix and organizing:
|
kobros-tech
force-pushed
the
17.0-mig-attribute_set
branch
2 times, most recently
from
322cddd to
5b7303f
Compare
kobros-tech
force-pushed
the
17.0-mig-attribute_set
branch
from
5b7303f to
b1434ab
Compare
We are at the point of cleanup and then review. just curious, was this used on other types of sites and not odoo _website? I had planned to make the module compatible with the e-commerce and merge the attributes with templates and variables while ideating the variant selectors, on product_attribute_set. while we do not currently use odoo from ecom it seems to make sense to keep moving the native functionality closer to usable with the 18 rear only available and owl. should some review be done on when and why to use pim attribute_set over the properties that are on crm now? not sure if moving forward those serial properties will be on more things. but there seems to still be a need to control product templates level attribute values for the search and compare of products. |
|
Hi @rousseldenis , @rvalyi I assure that this version is at the same quality as the older version and even move efficient. Please, review and merge if you are comfortable, and I only requested to delay the merge util I fix the issues that I suspected and you will observe the outcome. Thanks, and I will remind you of what Mr. Don said about extending this project to show product attributes on website e-commerce. We need your opinion... |
No description provided.