Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] product_attribute_set: Migration to 17.0 #191

Open
wants to merge 44 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] product_attribute_set: Migration to 17.0 #191

wants to merge 44 commits into from

Conversation

dnplkndll
Copy link

@dnplkndll dnplkndll commented Feb 5, 2025 •
edited
Loading

clementmbr and others added 30 commits February 4, 2025 22:47
@clementmbr @dnplkndll
[REF] rename modules based on attribute_set and pim
448f9e0 
New organization :

- attribute_set (former base_custom_attribute)
- product_attribute_set (former pim_custom_attribute but without menus)
- pim (The "PIM application" former pim_base)
- pim_attrubute_set (depends on product_attribute_set and adds menus in
the PIM application)
@clementmbr @dnplkndll
[REF] rename 'attribute_nature' field into 'nature'
69d4098 
And small FIX in _build_attribute_field()
@clementmbr @dnplkndll
[IMP] Add REAME to the 4 modules
8397594
@clementmbr @dnplkndll
[IMP] Move Product's attributes_placeholder to product_attribute_set
86d68c8
@clementmbr @dnplkndll
[IMP] remove class in super() and other misc improvements
86d39ef
@clementmbr @dnplkndll
[FIX] remove tests in product_attribute_set
96d3478
@clementmbr @dnplkndll
[REF] remove @api.multi
984d855 
[UPD] README.rst

[UPD] README.rst
@rousseldenis @dnplkndll
[13.0] Set modules to installable False
46b8627
@rousseldenis @dnplkndll
[13.0] Set modules version to 13
4376a56
@rousseldenis @dnplkndll
[13.0][MIG] product_attribute_set
ad73645 
[UPD] README.rst
@dnplkndll
[MIG] make all modules uninstallable
1252dc9
@dnplkndll
[MIG] update pre-commit conf from copier
011790f
@dnplkndll
[IMP] product_attribute_set: black, isort, prettier
9046f8f
@dnplkndll
[MIG] product_attribute_set: Migration to 14.0
f4e9a93 
[UPD] README.rst

[UPD] README.rst

[ADD] icon.png
@dnplkndll
[FIX] product_category multiple write
eb359f3 
courtesy of <olivier@naya-tec.com>

Apply dotfiles

[UPD] Update product_attribute_set.pot
@BorjaGarciaRouco @dnplkndll
Added translation using Weblate (Spanish)
a68fdba 
[UPD] Update product_attribute_set.pot
@oca-transbot @dnplkndll
Update translation files
bcd9726 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: odoo-pim-14.0/odoo-pim-14.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-14-0/odoo-pim-14-0-product_attribute_set/
@ibuioli @dnplkndll
Added translation using Weblate (Spanish (Argentina))
78f6d11
@ibuioli @dnplkndll
Translated using Weblate (Spanish (Argentina))
8ef1239 
Currently translated at 100.0% (27 of 27 strings)

Translation: odoo-pim-14.0/odoo-pim-14.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-14-0/odoo-pim-14-0-product_attribute_set/es_AR/
@chandni299 @dnplkndll
[IMP] product_attribute_set: black, isort, prettier
ace2fa7
@sbejaoui @dnplkndll
[16.0][MIG] - product_attribute_set
6414b6e
@glitchov @dnplkndll
[16.0][MIG] - product_attribute_set: add trnaslation fr_BE
045abdf
@glitchov @dnplkndll
[16.0][MIG] - product_attribute_set: improve product view
e0515cc
@sbejaoui @dnplkndll
[IMP] improve code
b2f7d13
@rousseldenis @dnplkndll
[IMP] product_attribute_set: Remove domain as computed in attribute_set
b3d0ab1 
See OCA#171
@Ivorra78 @dnplkndll
Translated using Weblate (Spanish)
7ad05c6 
Currently translated at 100.0% (15 of 15 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/es/
@ibuioli @dnplkndll
Translated using Weblate (Spanish (Argentina))
7c6a453 
Currently translated at 100.0% (15 of 15 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/es_AR/
@kbentaleb @dnplkndll
Added translation using Weblate (French)
5530bcc
@kbentaleb @dnplkndll
Translated using Weblate (French)
8f4bd73 
Currently translated at 80.0% (12 of 15 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/fr/
@mymage @dnplkndll
Added translation using Weblate (Italian)
8e9d72e
Ömer KÜLAK and others added 6 commits February 4, 2025 22:52
@dnplkndll
Translated using Weblate (Turkish)
4438503 
Currently translated at 100.0% (15 of 15 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/tr/
@mymage @dnplkndll
Translated using Weblate (Italian)
67ac9a1 
Currently translated at 100.0% (17 of 17 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/it/
@ibuioli @dnplkndll
Translated using Weblate (Spanish (Argentina))
7e481bf 
Currently translated at 100.0% (17 of 17 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/es_AR/
@Vandan-OSI @dnplkndll
[IMP] product_attribute_set: pre-commit execution
b164806
@Vandan-OSI @dnplkndll
[MIG]product_attribute_set: Migration to 17.0
3555cc7
@dnplkndll
[IMP] lint
6626f4e
@dnplkndll dnplkndll force-pushed the 17.0-MIG-product_attribute_set branch 2 times, most recently from ecf5dea to 805ab58 Compare February 5, 2025 04:03
rousseldenis
rousseldenis reviewed Feb 5, 2025
View reviewed changes
product_attribute_set/test-requirements.txt Outdated
@@ -0,0 +1 @@
odoo-addon-attribute_set @ git+https://github.com/OCA/odoo-pim.git@refs/pull/190/head#subdirectory=attribute_set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
odoo-addon-attribute_set @ git+https://github.com/OCA/odoo-pim.git@refs/pull/190/head#subdirectory=attribute_set
odoo-addon-attribute-set @ git+https://github.com/OCA/odoo-pim.git@refs/pull/190/head#subdirectory=setup/attribute_set

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not figured this out. works sometimes and other times does not but not clear how to trace the issue. updated the setup/ but I have tries this both ways on others with no luck

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug is fixed

@dnplkndll
@rousseldenis

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not figured this out. works sometimes and other times does not but not clear how to trace the issue. updated the setup/ but I have tries this both ways on others with no luck

@dnplkndll You can see it in build logs of tests or runboat.

The correct procedure is explained there: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@rousseldenis
Copy link
Contributor

/ocabot migration product_attribute_set

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Feb 5, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 5, 2025
Open
2 tasks
@rousseldenis
Copy link
Contributor

@dnplkndll Thanks for this. In order to help reviewers, don't hesitate to put depending PR's link in this description

@dnplkndll dnplkndll force-pushed the 17.0-MIG-product_attribute_set branch from 805ab58 to f241137 Compare February 5, 2025 12:18
@dnplkndll dnplkndll changed the title [17.0][MIG] product_attribute_set [17.0][MIG] product_attribute_set: Migration to 17.0 Feb 5, 2025
@kobros-tech kobros-tech force-pushed the 17.0-MIG-product_attribute_set branch from f241137 to e6189b8 Compare February 6, 2025 17:57
@kobros-tech kobros-tech mentioned this pull request Feb 6, 2025
Open
2 tasks
@kobros-tech kobros-tech force-pushed the 17.0-MIG-product_attribute_set branch from e6189b8 to 91f7326 Compare February 10, 2025 11:40
@kobros-tech kobros-tech force-pushed the 17.0-MIG-product_attribute_set branch from 91f7326 to 07360bd Compare February 11, 2025 01:02
wlin-kencove
wlin-kencove approved these changes Feb 21, 2025
View reviewed changes
Copy link

@wlin-kencove wlin-kencove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested setting the category attribute sets.

Products under the category will get the defaulted attribute set.

Attribute set on the product will enable the attribute tab on the product .

@kobros-tech
Copy link

@rousseldenis , @rvalyi

Ready to merge

@kobros-tech kobros-tech force-pushed the 17.0-MIG-product_attribute_set branch from cc19793 to 7d4db49 Compare February 23, 2025 14:44
@kobros-tech kobros-tech force-pushed the 17.0-MIG-product_attribute_set branch from 7d4db49 to 8057a41 Compare February 23, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@wlin-kencove wlin-kencove wlin-kencove approved these changes

@kobros-tech kobros-tech kobros-tech approved these changes

Assignees
No one assigned
Labels
approved migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.