Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] operating_unit: Migration to 17.0 #667

Merged
merged 85 commits into from
Jul 3, 2024

Conversation

jdidderen-nsi
Copy link
Contributor

Compare to 16.0, I added a new method in the model "res.users". The method is inspired by the one on companies (https://github.com/odoo/odoo/blob/7266a662171fedc945523c5bc1bb34a4dd0995bf/odoo/api.py#L645) in the idea that at some point maybe a selector widget (like company one) will be added to choose the active OUs

sudhir-serpentcs and others added 30 commits May 27, 2024 11:59
* [MIG] operating_unit to v10.0
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pandoc-3.2-1-amd64.deb Outdated Show resolved Hide resolved
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the migration and the refactor. Functional tests are good so far. Tested it using the migration of the account_operating_unit module for it. When the uneeded file is removed then I am fine with a merge.

@yankinmax
Copy link

@AaronHForgeFlow @gurneyalex
Can you pls help to get this merged?

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-667-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 55532ff into OCA:17.0 Jul 3, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 549a3b0. Thanks a lot for contributing to OCA. ❤️

@jdidderen-nsi
Copy link
Contributor Author

Just a quick message to thanks everyone for the help and the reviews on these modules.

FYI I will probably work on operating units during OCA days. For now, I have two improvements :

  • Have a selector widget in the same approach as multi-company
  • Improve report_qweb_operating_unit to have a different layout per operating unit (e.g having boxed in OU1 and stripped on OU2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.