Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] res_partner_operating_unit: Migration to 17.0 #678

Merged
merged 16 commits into from
Jul 19, 2024
Merged

[17.0][MIG] res_partner_operating_unit: Migration to 17.0 #678

merged 16 commits into from
Jul 19, 2024

Conversation

yankinmax
Copy link

@yankinmax yankinmax commented Jun 4, 2024 •
edited by gurneyalex
Loading

vvrossem
vvrossem reviewed Jun 6, 2024
View reviewed changes
Copy link

@vvrossem vvrossem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a doubt regarding the usage of Command.set instead of Command.link, unless using '4' in the first place was wrong,

res_partner_operating_unit/models/res_users.py Outdated Show resolved Hide resolved
res_partner_operating_unit/models/res_users.py Outdated Show resolved Hide resolved
@yankinmax yankinmax force-pushed the 17.0-mig-res_partner_operating_unit branch 2 times, most recently from 3081bde to f7a8126 Compare June 7, 2024 04:58
@yankinmax yankinmax force-pushed the 17.0-mig-res_partner_operating_unit branch from 2b58f03 to 294ba6d Compare June 11, 2024 13:46
Camille0907
Camille0907 approved these changes Jun 17, 2024
View reviewed changes
Copy link

@Camille0907 Camille0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM :)

@yankinmax yankinmax force-pushed the 17.0-mig-res_partner_operating_unit branch from 294ba6d to 0bade30 Compare June 25, 2024 16:14
ivantodorovich
ivantodorovich approved these changes Jun 27, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
res_partner_operating_unit/models/res_partner.py Outdated Show resolved Hide resolved
@yankinmax yankinmax force-pushed the 17.0-mig-res_partner_operating_unit branch from 0bade30 to 59a24c7 Compare June 28, 2024 10:10
repodevs and others added 15 commits July 8, 2024 16:49
@repodevs @yankinmax
res_partner_operating_unit
7178df8 
This module introduces Operating Unit in res partner
@repodevs @yankinmax
res_partner_operating_unit: fix error import models
9041102
@repodevs @yankinmax
res_partner_operating_unit: remove default assigned operating unit in…
fa13d35 
… partner
@repodevs @yankinmax
res_partner_operating_unit: fix manifest
ac649aa
@repodevs @yankinmax
res_partner_operating_unit: add unit tests
e8fea31
@repodevs @yankinmax
res_partner_operating_unit: fix flake8 error
91fae0b
@Dangar-Serpentcs @yankinmax
[12.0][MIG]res_partner_operating_unit.
250926e
@max3903 @yankinmax
[FIX] res_partner_operating_unit: Allow user to access his related pa…
70854a3 
…rtner
@max3903 @yankinmax
[FIX] res_partner_operating_unit: Perf issue (OCA#258)
62f3047
@patrickrwilson @yankinmax
[IMP] Add many2many_tags widget on list
b054736 
Added the many2many_tags widget on the list view.
@OCA-git-bot @yankinmax
res_partner_operating_unit 12.0.1.0.1
9e16fb2
@Dangar-Serpentcs @yankinmax
[FIX]Fixed an issue of getting trace-back when logged In user going t…
c433274 
…o change the Default Operating Unit.
@Dangar-Serpentcs @yankinmax
[MIG]res_partner_operating_unit: Migration to 13.0
bb8b948
@Freni-OSI @yankinmax
[14.0][MIG] res_partner_operating_unit
1fe79b5
@yankinmax
[IMP] res_partner_operating_unit: pre-commit auto fixes
dba6feb
@yankinmax yankinmax force-pushed the 17.0-mig-res_partner_operating_unit branch 2 times, most recently from f2cba3d to a8a1ca1 Compare July 8, 2024 18:33
epanisset
epanisset reviewed Jul 9, 2024
View reviewed changes
Copy link

@epanisset epanisset left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[False issue]

@yankinmax
Copy link
Author

@epanisset so we leave the current state?

@yankinmax yankinmax force-pushed the 17.0-mig-res_partner_operating_unit branch from a8a1ca1 to 653b55f Compare July 9, 2024 13:43
@epanisset
Copy link

@epanisset so we leave the current state?

what do you mean?

@yankinmax yankinmax force-pushed the 17.0-mig-res_partner_operating_unit branch from a499690 to 73a76a7 Compare July 9, 2024 16:57
@yankinmax
Copy link
Author

@gurneyalex PR is updated with your suggestions and checked functionally.
Can you trigger merge please?

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-678-by-gurneyalex-bump-nobump, awaiting test results.

@gurneyalex
Copy link
Member

/ocabot migration res_partner_operating_unit

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 19, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 19, 2024
Open
16 tasks
@OCA-git-bot OCA-git-bot merged commit a2fdbb4 into OCA:17.0 Jul 19, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c3a9552. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epanisset epanisset epanisset left review comments

@gurneyalex gurneyalex gurneyalex left review comments

@Camille0907 Camille0907 Camille0907 approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@jdidderen-nsi jdidderen-nsi Awaiting requested review from jdidderen-nsi

@vvrossem vvrossem Awaiting requested review from vvrossem

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.