-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0] partner_relations - Error when deleting a res.partner #154
Comments
Tests are not mandatory for now in OCA to not discourage the contributions, and the review process usually detect these things. I also think that this module is not the guilty, but something is happening. |
Is |
@rafaelbn just tested on Please try to reproduce it on a new database, pointing out the modules to install. Traceback would be useful too. Thanks |
As a rule of thumb, I always press Update in the This bug seems to me more related to #120 than to #139. You can sniff all the code in And also you should try what @eLBati says. |
The error I get is:
The error I get is:
Something between partners_firstname and partner_relations it's happening. Because why with all modules installed the error get fixed when uninstalling partner_firstname? Please let me know, thanks. |
|
Please @antespi could you review this issue? Thanks |
@eLBati did you chack this? #154 (comment) Thanks |
put some breakpoints in the triggers involved, I assume some trigger tries to read the deleted patner afterwards |
@hbrunn @eLBati @pedrobaeza @antespi @yajo question: if anyone add the test of deleting a partner in all modules in repo partner-contact then we will see when it happends. And by the way is a nice test. |
The point is that Let me guess that any module adding a computed field to I'm fixing Does anybody know what is |
Testing #171 with #170 I discovered accidentally that partner_event is affected too:
|
@yajo set a breakpoint in https://github.com/OCA/OCB/blob/8.0/openerp/fields.py#L53 and inspect what's going on when the failed value is created. Afterwards, the backtrace doesn't help a lot |
One funny thing: if you remove this read() method, the bug is fixed in all other modules. The bug resides in that method. I tested manually and with the tests in #170. But This module needs much love. Migrating to v8 api would benefit it a lot (or to a more readable v7, it's very low-level even for that). And a test suite is a must for it. I hope I have helped you to triage it, but I'm not going to touch this module's source for now. I'll keep #170 until you wish to merge it, as it does not hurt. |
This is not fixed. See #170 (comment). |
@pedrobaeza @hbrunn I reopen this issue again. As @yajo says is not fixed. I have tested in this moment again in OCA runbot (partner-contact) and we still cannot delete a res.partner. Problem is in module partner_relations (users could help @bwrsandman @antespi @hbrunn )
From #103 |
…ed together, get AccessError: ('AccessError', 'No value found for res.partner(43,).birthdate_date') See OCA#154
Hello, see my fix proposal at #200 |
Fixed here: #200 Please review, thanks |
…ed together, get AccessError: ('AccessError', 'No value found for res.partner(43,).birthdate_date') See OCA#154
…ed together, get AccessError: ('AccessError', 'No value found for res.partner(43,).birthdate_date') See OCA#154
Tested in OCA's runbot
https://runbot.odoo-community.org/runbot/repo/github-com-oca-partner-contact-134
I have tested in Odoo's runbot and you can delete any res.partner if it hasn't any other relation with other objects.
Maybe this bug it not from this module partner_contact_birthdate
@pedrobaeza I think that any module in this project must at least pass test of creating, modifying and deleting a res.partner, if not shouldn't be merged.
cc @sysadminmatmoz @yajo
The text was updated successfully, but these errors were encountered: