Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] pass load in load override #171

Merged
merged 1 commit into from
Sep 18, 2015
Merged

[FIX] pass load in load override #171

merged 1 commit into from
Sep 18, 2015

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Sep 8, 2015

fixes #154

@hbrunn hbrunn mentioned this pull request Sep 8, 2015
Closed
@pedrobaeza
Copy link
Member

So this little argument is the origin of all the evil... let's fix it!

👍

@hbrunn hbrunn mentioned this pull request Sep 8, 2015
Merged
@hbrunn hbrunn added this to the 8.0 milestone Sep 8, 2015
@hbrunn hbrunn mentioned this pull request Sep 8, 2015
Closed
@pedrobaeza
Copy link
Member

@hbrunn, another thing you have to fixed as mention by @yajo is the depends section of the module. You must depend at least from base.

@hbrunn
Copy link
Member Author

hbrunn commented Sep 9, 2015

@pedrobaeza elaborate please. The base dependency is implicit nowadays, isn't it?

@pedrobaeza
Copy link
Member

No, it isn't, please see rationale here: OCA/maintainer-tools#91 (comment)

@hbrunn
Copy link
Member Author

hbrunn commented Sep 9, 2015

@pedrobaeza weird, what is described there shouldn't happend. Anyways: #173

@guewen
Copy link
Member

guewen commented Sep 9, 2015

👍

@yajo
Copy link
Member

yajo commented Sep 9, 2015

Sad to say, but this fix does not pass tests in #154.

@hbrunn
Copy link
Member Author

hbrunn commented Sep 9, 2015

well, it's not merged yet, so of course ci tests still fail in #154

@yajo
Copy link
Member

yajo commented Sep 9, 2015

I mean after merging this on top of #154. I'm going to try now on an empty DB, let's see.

@yajo
Copy link
Member

yajo commented Sep 9, 2015

Sorry, I meant #170.

@yajo
Copy link
Member

yajo commented Sep 9, 2015

Empty DB. Tests in #170 fail, manual tests too. Definitely not working, sorry.

@yajo yajo mentioned this pull request Sep 14, 2015
Merged
@antespi
Copy link
Contributor

antespi commented Sep 18, 2015

👍 Anyway this fix is neccesary, because it is needed in https://github.com/OCA/partner-contact/blob/8.0/partner_relations/model/res_partner_relation.py#L356

@pedrobaeza
Copy link
Member

I merge this one and we can continue seeing unlink test in its issue/another PR

pedrobaeza added a commit that referenced this pull request Sep 18, 2015
@pedrobaeza
Merge pull request #171 from hbrunn/8.0-partner_relations_pass_load
0c0503a 
[FIX] pass load in load override
@pedrobaeza pedrobaeza merged commit 0c0503a into OCA:8.0 Sep 18, 2015
yvaucher pushed a commit to yvaucher/partner-contact that referenced this pull request Jan 18, 2016
@yvaucher
After all, this was just a workaround. Remove it.
398a1f5 
The real fix was in OCA#171. I leave the tests.
yvaucher pushed a commit to yvaucher/partner-contact that referenced this pull request Jan 18, 2016
@yvaucher
After all, this was just a workaround. Remove it.
21c63b4 
The real fix was in OCA#171. I leave the tests.
etobella pushed a commit to etobella/partner-contact that referenced this pull request Oct 9, 2017
@etobella
After all, this was just a workaround. Remove it.
d088803 
The real fix was in OCA#171. I leave the tests.
etobella pushed a commit to etobella/partner-contact that referenced this pull request Oct 10, 2017
@etobella
After all, this was just a workaround. Remove it.
7816398 
The real fix was in OCA#171. I leave the tests.
JordiBForgeFlow pushed a commit to ForgeFlow/partner-contact that referenced this pull request Nov 17, 2017
@JordiBForgeFlow
After all, this was just a workaround. Remove it.
a968d29 
The real fix was in OCA#171. I leave the tests.
gdgellatly pushed a commit to odoonz/partner-contact that referenced this pull request Oct 29, 2018
@gdgellatly
After all, this was just a workaround. Remove it.
d26074e 
The real fix was in OCA#171. I leave the tests.
gdgellatly pushed a commit to odoonz/partner-contact that referenced this pull request Nov 6, 2018
@gdgellatly
Fix bug OCA#154.
f6d5863 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
yajo pushed a commit that referenced this pull request Nov 22, 2018
@yajo
Fix bug #154.
5179935 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in #171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
victormmtorres pushed a commit to Tecnativa/partner-contact that referenced this pull request Mar 25, 2019
@yajo
Fix bug OCA#154.
b6c513b 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
rven pushed a commit to rven/partner-contact that referenced this pull request Sep 30, 2019
@rven
Fix bug OCA#154.
af15611 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
rven pushed a commit to rven/partner-contact that referenced this pull request Oct 26, 2019
@rven
Fix bug OCA#154.
4062f76 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
ermannognan pushed a commit to ermannognan/partner-contact that referenced this pull request Nov 25, 2019
@ermannognan
Fix bug OCA#154.
ee59992 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
luistorresm pushed a commit to vauxoo-dev/partner-contact that referenced this pull request Oct 12, 2020
@luistorresm
Fix bug OCA#154.
402a40d 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
bjornbillen pushed a commit to bjornbillen/partner-contact that referenced this pull request Nov 12, 2021
@bjornbillen
Fix bug OCA#154.
db6b02a 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
bjornbillen pushed a commit to bjornbillen/partner-contact that referenced this pull request Feb 8, 2022
@bjornbillen
Fix bug OCA#154.
8fd7684 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
FrancoMaxime pushed a commit to acsone/partner-contact that referenced this pull request Aug 24, 2022
@FrancoMaxime
Fix bug OCA#154.
e16058b 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
baimont pushed a commit to acsone/partner-contact that referenced this pull request Oct 6, 2022
@baimont
Fix bug OCA#154.
209f7d5 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
victor-champonnois pushed a commit to coopiteasy/partner-contact that referenced this pull request Feb 3, 2023
@victor-champonnois
Fix bug OCA#154.
ec7bc60 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
moitabenfdz pushed a commit to DynAppsNV/partner-contact that referenced this pull request Nov 16, 2023
@moitabenfdz
Fix bug OCA#154.
28ec3de 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
edlopen pushed a commit to moduon/partner-contact that referenced this pull request Mar 1, 2024
@edlopen
Fix bug OCA#154.
4e7682d 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
edlopen pushed a commit to moduon/partner-contact that referenced this pull request Mar 1, 2024
@edlopen
Fix bug OCA#154.
30b7d53 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
SonoDavid pushed a commit to DynAppsNV/partner-contact that referenced this pull request Oct 14, 2024
Fix bug OCA#154.
b778ef9 
Conflicts:
	partner_firstname/__openerp__.py
	partner_firstname/tests/__init__.py

Fix flake8 error

After all, this was just a workaround. Remove it.

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

PEP8 fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.0
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@hbrunn @pedrobaeza @guewen @yajo @antespi @yvaucher