Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cities did not pull to correct states #749

Closed
hiltonmw opened this issue Jun 18, 2019 · 13 comments
Closed

Cities did not pull to correct states #749

hiltonmw opened this issue Jun 18, 2019 · 13 comments

Comments

@hiltonmw
Copy link

Hi there,

I did my first import from geonames just yesterday and I'm noticing today that many of the cities that have the same name in multiple states did not get imported correctly. For example, Worcester, the city, resides in MA, NY, PA, and VT. But upon import, it's placed ALL cities named Worcester into VT. (see screenshots for a few examples)...

cities_error_1
cities_error_2

@pedrobaeza
Copy link
Member

Which Odoo version?

@hiltonmw
Copy link
Author

Odoo 12, CE

@hiltonmw
Copy link
Author

any other thoughts on this @pedrobaeza ?

@pedrobaeza
Copy link
Member

Not right now. I'll check next week when coming from holidays

@hiltonmw
Copy link
Author

Hi Pedro...

Any updates on this? I need to build up my production server and I'm concerned this bug will follow me there and I'd like it if it doesn't. Thanks!

@hiltonmw
Copy link
Author

For what it's worth, I just spun up a completely new instance of Odoo 12 CE - installed the addon/extra and it did the same exact thing. Ubuntu Server 18.04 x64 with Odoo 12 CE. All up to date with latest patches/updates/etc.

@pedrobaeza
Copy link
Member

I come back from holidays tomorrow, and I'll need sometime to find the problem.

@hiltonmw
Copy link
Author

So sorry to pester, but I'm trying to go live with this and I was wondering if there's been any headway on this.

@hiltonmw
Copy link
Author

hiltonmw commented Jul 2, 2019

@pedrobaeza - Is there any update on this? I'm sorry to continue to pester, but without this working properly I'm kind of stuck with setting up my production database, as I don't want to manually input data if it will disrupt your/our troubleshooting in any way...

@pedrobaeza
Copy link
Member

Sorry but no. This is not top priority for me, and although I confirm there's a bug, I need some free time for checking and solving. I will try this week.

@hiltonmw
Copy link
Author

Hi Pedro,

Any luck on a fix for this yet? Has it always been broken or is there something unique about how it runs now that causes it to break?

Thanks-
-Matt

pedrobaeza added a commit to Tecnativa/partner-contact that referenced this issue Jul 29, 2019
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
@pedrobaeza
Copy link
Member

You can find the fix in #757

kongrattapong pushed a commit to ecosoft-odoo/partner-contact that referenced this issue Aug 21, 2019
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
pedrobaeza added a commit to Tecnativa/partner-contact that referenced this issue Sep 30, 2019
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
pedrobaeza added a commit to Tecnativa/partner-contact that referenced this issue Oct 4, 2019
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
chienandalu pushed a commit to Tecnativa/partner-contact that referenced this issue Nov 28, 2019
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
kongrattapong pushed a commit to ecosoft-odoo/partner-contact that referenced this issue Nov 29, 2019
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
alexis-via pushed a commit to akretion/partner-contact that referenced this issue Nov 26, 2020
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
pedrobaeza added a commit to Tecnativa/partner-contact that referenced this issue Dec 15, 2020
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
pedrobaeza added a commit to Tecnativa/partner-contact that referenced this issue Nov 16, 2021
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
holdenrehg pushed a commit to holdenrehg/partner-contact that referenced this issue Nov 27, 2021
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
holdenrehg pushed a commit to holdenrehg/partner-contact that referenced this issue Nov 27, 2021
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
pedrobaeza added a commit to Tecnativa/partner-contact that referenced this issue Oct 18, 2022
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
victor-champonnois pushed a commit to coopiteasy/partner-contact that referenced this issue Feb 3, 2023
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
royaurelien pushed a commit to apikcloud/partner-contact that referenced this issue Jan 24, 2024
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
pedrobaeza added a commit to Tecnativa/partner-contact that referenced this issue Feb 29, 2024
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
edlopen pushed a commit to moduon/partner-contact that referenced this issue Mar 1, 2024
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
edlopen pushed a commit to moduon/partner-contact that referenced this issue Mar 1, 2024
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
Kimkhoi3010 pushed a commit to Kimkhoi3010/partner-contact that referenced this issue Oct 15, 2024
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.

We amend this storing in the cached dictionary both city name and state.

Includes a test for checking this specific condition, got from real data in US.

Fixes OCA#749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@pedrobaeza @hiltonmw and others