[FIX] base_location_geonames_import: Handle duplicated city names #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are several cities with the same name in different states, previous code doesn't handle correctly this situation. We amend this storing in the cached dictionary both city name and state. Includes a test for checking this specific condition, got from real data in US. Fixes OCA#749
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
This PR has the |
OCA-git-bot
added a commit
that referenced
this pull request
Aug 9, 2019
|
Congratulations, your PR was merged at a1aa89c. Thanks a lot for contributing to OCA. ❤️ PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into |
chienandalu
pushed a commit
to Tecnativa/partner-contact
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are several cities with the same name in different states, previous code doesn't
handle correctly this situation.
We amend this storing in the cached dictionary both city name and state.
Includes a test for checking this specific condition, got from real data in US.
Fixes #749
cc @Tecnativa