[17.0] [MIG] partner_industry_secondary #1679

mmrondon · 2024-02-28T21:45:33Z

No description provided.

Currently translated at 83.3% (15 of 18 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_industry_secondary/hr/

Currently translated at 88.9% (16 of 18 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_industry_secondary/es/

…when create a company with 2 contacts

Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_industry_secondary/ca/

Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/fr/

Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/

Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/es/

Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/it/

…ield As asked by Odoo in a warning in _check_parent_path method https://github.com/odoo/odoo/blob/16.0/odoo/models.py#L2615

DucTruongKomit

LGTM! All gud!

HaraldPanten · 2024-05-15T07:16:45Z

@mmrondon You have too many commits for this migration. Don't you?

Could you clean the commits and leave only what we need for the migration?

THX.

[IMP] Fix pre-commit and unit tests [IMP] partner_industry_secondary: black, isort, prettier [IMP] partner_industry_secondary: Update unit tests [IMP] partner_industry_secondary: black, isort, prettier

Tisho99

Hi @mmrondon

I have made a functional and code review and this migration looks good.

However, i found that you haven't applied some steps of the migration guide

Can you review and apply my suggestions in your last commit?

Then this will be ready for merge

Thank you!

Tisho99 · 2024-05-17T09:43:15Z

partner_industry_secondary/views/res_config_settings.xml

+                <div class="row mt16 o_settings_container">
+                    <div class="col-lg-6 o_setting_box">
+                        <div class="o_setting_left_pane">
+                            <field name="group_use_partner_industry_for_person" />
+                        </div>
+                        <div
+                            class="o_setting_right_pane"
+                            id="partner_industry_secondary_show_form_settings"
+                        >
+                            <label
+                                string="Enable industries for individuals"
+                                for="group_use_partner_industry_for_person"
+                            />
+                            <div class="text-muted">
+                                Enable industries for individuals
+                             </div>
+                            <div class="content-group">
+                                <div
+                                    class="mt16"
+                                    invisible="group_use_partner_industry_for_person == False"
+                                >
+                                    <button
+                                        name="%(base.res_partner_industry_action)d"
+                                        icon="fa-arrow-right"
+                                        type="action"
+                                        string="Industries"
+                                        class="btn-link"
+                                    />
+                                </div>
+                            </div>
+                        </div>
+                    </div>
+                </div>


Suggested change

<div class="row mt16 o_settings_container">

<div class="col-lg-6 o_setting_box">

<div class="o_setting_left_pane">

<field name="group_use_partner_industry_for_person" />

</div>

<div

class="o_setting_right_pane"

id="partner_industry_secondary_show_form_settings"

>

<label

string="Enable industries for individuals"

for="group_use_partner_industry_for_person"

/>

<div class="text-muted">

Enable industries for individuals

</div>

<div class="content-group">

<div

class="mt16"

invisible="group_use_partner_industry_for_person == False"

>

<button

name="%(base.res_partner_industry_action)d"

icon="fa-arrow-right"

type="action"

string="Industries"

class="btn-link"

/>

</div>

</div>

</div>

</div>

</div>

<block>

<setting string="Enable industries for individuals" help="Enable industries for individuals">

<field name="group_use_partner_industry_for_person" />

</setting>

</block>

Tisho99 · 2024-05-17T09:46:26Z

partner_industry_secondary/views/res_partner_view.xml

+                    name="industry_id"
+                    invisible="is_company == False and show_partner_industry_for_person == False"
+                />
+                <field name="show_partner_industry_for_person" invisible="1" />


Suggested change

<field name="show_partner_industry_for_person" invisible="1" />

<field name="show_partner_industry_for_person" column_invisible="1" />

HaraldPanten · 2024-05-21T10:48:19Z

Superseded by #1761

MiquelRForgeFlow and others added 26 commits February 28, 2024 15:55

partner_sector -> partner_industry_secondary

a2fe7c0

Migration scripts (from v10 to v11)

6dd406b

partner_industry_secondary: Migration to v12

96fdfa0

partner_industry_Secondary: Make api constrains multi to avoid error …

4931c71

…when create a company with 2 contacts

[IMP] partner_industry_secondary: black, isort, prettier

7b2e482

[MIG] partner_industry_secondary: Migration to 13.0

e36a030

[IMP] : black, isort, prettier

de83f15

[MIG] partner_industry_secondary: Migration to 14.0

5cdcb5f

[IMP] partner_industry_secondary: black, isort, prettier

8738453

[MIG] partner_industry_secondary: Migration to 15.0

551ff69

[MIG] partner_industry_secondary: Migration to 16.0

8573dac

fixup! [MIG] partner_industry_secondary: Migration to 16.0

4f87012

[UPD] Update partner_industry_secondary.pot

94f88ba

[UPD] README.rst

3cf1b88

[UPD] README.rst

3496fe4

[IMP] partner_industry_secondary: add unaccent=False on parent_path f…

8044a9f

…ield As asked by Odoo in a warning in _check_parent_path method https://github.com/odoo/odoo/blob/16.0/odoo/models.py#L2615

[BOT] post-merge updates

9a2fabc

[IMP] partner_industry_secondary: pre-commit auto fixes

fb5a274

mmrondon changed the title ~~17.0 mig partner industry secondary~~ [17.0] [MIG] partner_industry_secondary Feb 28, 2024

This comment was marked as resolved.

Sign in to view

DucTruongKomit approved these changes May 10, 2024

View reviewed changes

[MIG] partner_industry_secondary: Migration to 17.0

39a6423

[IMP] Fix pre-commit and unit tests [IMP] partner_industry_secondary: black, isort, prettier [IMP] partner_industry_secondary: Update unit tests [IMP] partner_industry_secondary: black, isort, prettier

mmrondon force-pushed the 17.0-mig-partner_industry_secondary branch from 0a85af5 to 39a6423 Compare May 15, 2024 19:17

Tisho99 suggested changes May 17, 2024

View reviewed changes

Tisho99 mentioned this pull request May 21, 2024

[17.0] [MIG] partner_industry_secondary #1761

Merged

HaraldPanten closed this May 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0] [MIG] partner_industry_secondary #1679

[17.0] [MIG] partner_industry_secondary #1679

mmrondon commented Feb 28, 2024

This comment was marked as resolved.

DucTruongKomit left a comment

HaraldPanten commented May 15, 2024

Tisho99 left a comment

Tisho99 May 17, 2024

Tisho99 May 17, 2024

HaraldPanten commented May 21, 2024

	<field name="show_partner_industry_for_person" invisible="1" />
	<field name="show_partner_industry_for_person" column_invisible="1" />

[17.0] [MIG] partner_industry_secondary #1679

[17.0] [MIG] partner_industry_secondary #1679

Conversation

mmrondon commented Feb 28, 2024

This comment was marked as resolved.

DucTruongKomit left a comment

Choose a reason for hiding this comment

HaraldPanten commented May 15, 2024

Tisho99 left a comment

Choose a reason for hiding this comment

Tisho99 May 17, 2024

Choose a reason for hiding this comment

Tisho99 May 17, 2024

Choose a reason for hiding this comment

HaraldPanten commented May 21, 2024