-
-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0] [MIG] partner_industry_secondary #1761
[17.0] [MIG] partner_industry_secondary #1761
Conversation
Currently translated at 83.3% (15 of 18 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_industry_secondary/hr/
Currently translated at 88.9% (16 of 18 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_industry_secondary/es/
…when create a company with 2 contacts
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_industry_secondary/ca/
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/fr/
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/es/
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/it/
…ield As asked by Odoo in a warning in _check_parent_path method https://github.com/odoo/odoo/blob/16.0/odoo/models.py#L2615
ba99db2
to
8846462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some changes.
def _compute_display_name(self): | ||
for rec in self: | ||
if rec.parent_id: | ||
rec.display_name = rec.parent_id.display_name + " / " + rec.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change it to .format .
and in line 52/49
default["name"] = self.name + " 2"
391deb4
to
b3a536e
Compare
b3a536e
to
34cc5a7
Compare
/ocabot migration partner_industry_secondary |
[IMP] Fix pre-commit and unit tests [IMP] partner_industry_secondary: black, isort, prettier [IMP] partner_industry_secondary: Update unit tests [IMP] partner_industry_secondary: black, isort, prettier
34cc5a7
to
9d85188
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review. LGTM
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at faa1e74. Thanks a lot for contributing to OCA. ❤️ |
Supersedes #1679
T-6089