Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [MIG] partner_industry_secondary #1761

Merged

Conversation

Tisho99
Copy link

@Tisho99 Tisho99 commented May 21, 2024

Supersedes #1679

T-6089

MiquelRForgeFlow and others added 25 commits February 28, 2024 15:55
Currently translated at 83.3% (15 of 18 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_industry_secondary/hr/
Currently translated at 88.9% (16 of 18 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_industry_secondary/es/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-15.0/partner-contact-15.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_industry_secondary/ca/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/fr/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/es/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/it/
@Tisho99 Tisho99 changed the title 17.0 mig partner industry secondary [17.0] [MIG] partner_industry_secondary May 21, 2024
@Tisho99 Tisho99 force-pushed the 17.0-mig-partner_industry_secondary branch from ba99db2 to 8846462 Compare May 21, 2024 09:27
@Tisho99 Tisho99 marked this pull request as ready for review May 21, 2024 09:35
@Tisho99
Copy link
Author

Tisho99 commented May 21, 2024

Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes.

def _compute_display_name(self):
for rec in self:
if rec.parent_id:
rec.display_name = rec.parent_id.display_name + " / " + rec.name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change it to .format .
and in line 52/49
default["name"] = self.name + " 2"

@Tisho99 Tisho99 force-pushed the 17.0-mig-partner_industry_secondary branch from 391deb4 to b3a536e Compare May 21, 2024 10:34
@Tisho99 Tisho99 marked this pull request as draft May 21, 2024 10:38
@Tisho99 Tisho99 force-pushed the 17.0-mig-partner_industry_secondary branch from b3a536e to 34cc5a7 Compare May 21, 2024 10:46
@HaraldPanten
Copy link
Contributor

/ocabot migration partner_industry_secondary

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 21, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 21, 2024
65 tasks
[IMP] Fix pre-commit and unit tests

[IMP] partner_industry_secondary: black, isort, prettier

[IMP] partner_industry_secondary: Update unit tests

[IMP] partner_industry_secondary: black, isort, prettier
@Tisho99 Tisho99 force-pushed the 17.0-mig-partner_industry_secondary branch from 34cc5a7 to 9d85188 Compare May 21, 2024 10:51
Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Tisho99 Tisho99 marked this pull request as ready for review May 21, 2024 10:57
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. LGTM

@HaraldPanten
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1761-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d9edef1 into OCA:17.0 May 21, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at faa1e74. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 17.0-mig-partner_industry_secondary branch May 21, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.