[17.0][FIX] partner_firstname: fix error when creating a user from an employee #1725
Conversation
BurkhalterY
changed the title
|
This PR has the |
| @@ -65,6 +65,7 @@ def copy(self, default=None): | |||
| @api.model | |||
| def default_get(self, fields_list): | |||
| """Invert name when getting default values.""" | |||
| fields_list.append("name") | |||
There was a problem hiding this comment.
IMO, the proper fix is to do the stuff only if name if fields_list, not to force always to include that field in the results.
There was a problem hiding this comment.
Hi @pedrobaeza, I'm not sure to understand what do you propose, but I added a condition to add name only if firstname or lastname is in fields_list.
Let me know if there is a better solution
Steps to reproduce:
- Install `hr` and `partner_firstname`
- Go to Employees > any employee > action menu > Create User > Save
- 💥 Traceback
Suspected cause: in `defaul_get()`, the field `name` is not present in `fields_list` (probably because it's computed). So `result.get("name", "")` will always return `""` and `firstname` and `lastname` are not computed.
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at aa70256. Thanks a lot for contributing to OCA. ❤️ |
Steps to reproduce:
hrandpartner_firstnameSuspected cause: in
defaul_get(), the fieldnameis not present infields_list(probably because it's computed). Soresult.get("name", "")will always return""andfirstnameandlastnameare not computed.