Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] partner_firstname : bug "create and edit" from invoice and sale order #1794

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[17.0][FIX] partner_firstname : bug "create and edit" from invoice and sale order #1794

merged 1 commit into from
Jul 8, 2024

Conversation

rpinset
Copy link
Member

@rpinset rpinset commented Jun 28, 2024

Solve this issue #1757
Fix this PR #1725

@pedrobaeza I try again :)

@rpinset rpinset mentioned this pull request Jun 28, 2024
Closed
@pedrobaeza
Copy link
Member

pedrobaeza commented Jun 28, 2024 •
edited
Loading

You don't need an extra PR, but do a commit amend + push -f. Anyway, let's keep this new one. Take it into account for future occasions.

@pedrobaeza pedrobaeza changed the title [FIX] partner_firstname : bug "create and edit" from invoice and sale order [17.0][FIX] partner_firstname : bug "create and edit" from invoice and sale order Jun 28, 2024
@pedrobaeza pedrobaeza linked an issue Jun 28, 2024 that may be closed by this pull request
[17.0] Error when "create and edit" customer in invoice #1757
Closed
@pedrobaeza pedrobaeza added this to the 17.0 milestone Jun 28, 2024
@pedrobaeza pedrobaeza requested a review from BurkhalterY June 28, 2024 09:01
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BurkhalterY
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Sorry @BurkhalterY you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@BurkhalterY
Copy link
Member

@pedrobaeza Could you merge please?

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1794-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7c43224 into OCA:17.0 Jul 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 714edd0. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurkhalterY BurkhalterY BurkhalterY approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.

[17.0] Error when "create and edit" customer in invoice
4 participants
@rpinset @pedrobaeza @OCA-git-bot @BurkhalterY