-
-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] partner_affiliate #1741
[17.0][MIG] partner_affiliate #1741
Conversation
* [MIG] Migration of partner_affiliate to v11 * Fixing use of @Class and do not inheriting address from parent company * Improving legibility and details of fields * Fixing travis errors remove obsolete .pot files [ci skip] [UPD] Update partner_affiliate.pot
[IMP] partner_affiliate: Readme [IMP] Small readability improvements [FIX] Remove copyright from init files [UPD] README.rst [UPD] Update partner_affiliate.pot Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate. [UPD] Update partner_affiliate.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-12.0/partner-contact-12.0-partner_affiliate Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_affiliate/
[UPD] README.rst Translated using Weblate (Spanish) Currently translated at 100.0% (9 of 9 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_affiliate Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_affiliate/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-13.0/partner-contact-13.0-partner_affiliate Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_affiliate/
I tried to improve the description to be more precise about what this module does.
Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>
Currently translated at 100.0% (8 of 8 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_affiliate Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_affiliate/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-16.0/partner-contact-16.0-partner_affiliate Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_affiliate/
Currently translated at 44.4% (4 of 9 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_affiliate Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_affiliate/hr/
Currently translated at 100.0% (9 of 9 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_affiliate Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_affiliate/pt_BR/
Currently translated at 100.0% (9 of 9 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_affiliate Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_affiliate/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-16.0/partner-contact-16.0-partner_affiliate Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_affiliate/
Currently translated at 100.0% (9 of 9 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_affiliate Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_affiliate/it/
/ocabot migration partner_affiliate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Deriman-Alonso I think there's something missing.
1- Go to a contact form view (company)
2- Try to set a parent.
You'll not be able to set a parent. The field is invisible. Could you check?
<xpath | ||
expr="/form/sheet//div[hasclass('o_row')]/field[@name='parent_id']" | ||
position="attributes" | ||
> | ||
<attribute name="attrs" /> | ||
</xpath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's a standard behavior I overlooked it, but this inheritance does nothing since "attrs" is not used in v17.0. Nice catch @HaraldPanten
4b1700c
to
7bbf1e7
Compare
@HaraldPanten @Christian-RB You're right!. my apologies I slipped on that one, Its fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 0b5b447. Thanks a lot for contributing to OCA. ❤️ |
No description provided.