Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] partner_affiliate #1741

Merged
merged 33 commits into from
May 6, 2024

Conversation

Deriman-Alonso
Copy link
Member

No description provided.

Raúl Martín and others added 30 commits April 19, 2024 09:07
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
[IMP] partner_affiliate: Readme

[IMP] Small readability improvements

[FIX] Remove copyright from init files

[UPD] README.rst

[UPD] Update partner_affiliate.pot

Update translation files

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] Update partner_affiliate.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-12.0/partner-contact-12.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_affiliate/
[UPD] README.rst

Translated using Weblate (Spanish)

Currently translated at 100.0% (9 of 9 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_affiliate/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-13.0/partner-contact-13.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_affiliate/
I tried to improve the description to be more precise about what this module does.
Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>
Currently translated at 100.0% (8 of 8 strings)

Translation: partner-contact-15.0/partner-contact-15.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_affiliate/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-16.0/partner-contact-16.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_affiliate/
Currently translated at 44.4% (4 of 9 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_affiliate/hr/
Currently translated at 100.0% (9 of 9 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_affiliate/pt_BR/
Currently translated at 100.0% (9 of 9 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_affiliate/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-16.0/partner-contact-16.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_affiliate/
mymage and others added 2 commits April 19, 2024 09:07
Currently translated at 100.0% (9 of 9 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_affiliate/it/
@Deriman-Alonso Deriman-Alonso mentioned this pull request Apr 19, 2024
65 tasks
@pedrobaeza
Copy link
Member

/ocabot migration partner_affiliate

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 19, 2024
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Deriman-Alonso I think there's something missing.

1- Go to a contact form view (company)
2- Try to set a parent.

You'll not be able to set a parent. The field is invisible. Could you check?
Captura de Pantalla 2024-05-02 a las 16 33 18

Comment on lines 9 to 14
<xpath
expr="/form/sheet//div[hasclass('o_row')]/field[@name='parent_id']"
position="attributes"
>
<attribute name="attrs" />
</xpath>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's a standard behavior I overlooked it, but this inheritance does nothing since "attrs" is not used in v17.0. Nice catch @HaraldPanten

@Deriman-Alonso
Copy link
Member Author

@HaraldPanten @Christian-RB You're right!. my apologies I slipped on that one, Its fixed now.
Thanks for the review 👍.

Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HaraldPanten
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1741-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d1dde4c into OCA:17.0 May 6, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0b5b447. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.