Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] partner_identification: Add context override #373

Conversation

lasley
Copy link
Contributor

@lasley lasley commented Jan 21, 2017

  • Allow for context override of validations using __id_no_validate__

This was causing me some issues with an importer, where all data may not be good but is still required.

* Allow for context override of validations using ``__id_no_validate__``
@lasley lasley force-pushed the feature/10.0/partner_identificaton-context_override branch from 5d9830e to 8fc6b13 Compare January 21, 2017 22:19
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Code review

@pedrobaeza
Copy link
Member

You can put as context variable only id_no_validate for being shorter and clearer to pass the value I think.

@lmignon
Copy link
Contributor

lmignon commented Jan 23, 2017

@lasley I also prefer id_no_validate as key. Apart from this remark your proposal makes sense.

@lasley
Copy link
Contributor Author

lasley commented Jan 23, 2017

I prefer that naming as well. Done!

@@ -35,8 +35,15 @@ Name:
Code:
Code, abbreviation or acronym of this ID type. For example, 'driver_license'
Python validation code:
Optional python code called to validate ID numbers of this ID type.
Optional python code called to validate ID numbers of this ID type. This functionality can be
overridden by setting ``__id_no_validate__`` to ``True`` in the context, such as:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lasley s/__ id_no_validate __/id_no_validate

@lasley
Copy link
Contributor Author

lasley commented Jan 24, 2017

Thanks for the catch @lmignon, ReadMe updated

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lasley

@pedrobaeza pedrobaeza merged commit 76c2e7b into OCA:10.0 Jan 24, 2017
@lasley lasley deleted the feature/10.0/partner_identificaton-context_override branch January 24, 2017 18:12
lasley pushed a commit to LasLabs/vertical-medical that referenced this pull request Jul 10, 2017
Squashed commits:
[345fdd3] Allow Rx substitution using GCN if not same product
[bcfe1bd] Remove required from pathology in disease
[ee23f93] Fix day reference
[1b47c9f] Fix bugs and usability issues identified in LABS-362
Squashed commits:
[94b0b23] [IMP] medical_medicament_us: Improve nested NDC form
* Create custom nested NDC form with active toggle and split groups
[a8b8b33] [IMP] medical: Move active toggle to abstract entity
* Move active toggle button to abstract entity button box to reduce code dup
[6e50f1d] [IMP] medical_medicament_us: Add active flag
* Add an active flag for NDCs to allow for more granular reporting
[1ec637c] [FIX] medical_center: Move centers in patient view
* Move medical centers to right group in patient view, instead of title area
[b3657e5] [IMP] medical: Patient view xpaths
* Switch patient view xpaths to use pre-defined entity groups to provide commonality
[43451d3] [FIX] website_sale_medical_prescription: Fix gender attribute
[4117591] [FIX] website_medical_patient: Fix gender attribute
[038ec40] [FIX] sale_medical_prescription: Fix attributes
* Fix patients assigned as partners
* Fix usage of dosage quantity as order line
[7a3793f] [IMP] sale_stock_medical_prescription_us: Switch to product_uom
* Switch reference to use product_uom days instead of now nonexistent medicament
[1ce4261] [IMP] medical_medication: Remove uom data
* Remove UOM data in favor of product_uom, which contains the same thing now
[9be7200] [IMP] sale_stock_medical_prescription: Change rx force context key
* Change context key to force prescription dispenses from `__rx_force__` to `rx_no_validate` to match partner Id validate skip introduced in OCA/partner-contact#373
[3742154] [IMP] medical_patient_us: Activate module
[b7e00e7] [FIX] medical_medicament_us: Fix GCN display (#127)

* [FIX] medical_medicament_us: Fix GCN display
* Add `name_get` to display GCN with prepended zero pads.

* [IMP] medical_medicament_us: Change GCN to int
* Updates per PR

* [FIX] website_sale_medical_medicament_us: Fix GCN
* Update GCN to appropriate code
pankk pushed a commit to pankk/partner-contact that referenced this pull request Aug 10, 2018
(cherry picked from commit eadcae2)

Conflicts:
	partner_identification/__openerp__.py
	Set version to 8.0.1.0.0.
	Remove dependency on sales_team, as the relevant change is not
in 8.0.

Change emails to the new ones
(cherry picked from commit 3455ae6)

Update new name
(cherry picked from commit 5b592d7)

[FIX] try me on runbot link

(cherry picked from commit bd587b6)

Conflicts:
	partner_identification/README.rst
	Changed runbot to 8.0

[IMP] partner_identification: Add context override (OCA#373)

Allow for context override of validations using ``id_no_validate``
(cherry picked from commit 76c2e7b)

[10.0][IMP] partner_identification: Add field computation and inverses (OCA#419)

* [IMP] partner_identification: Add field computation and inverses
* Add methods to allow for computation and inverse of an ID field of a specific category type

* [IMP] partner_identification: Add search option

(cherry picked from commit 19c5fb6)

[FIX] partner_identification: Infinite loop in search (OCA#436)

(cherry picked from commit fa9b390)

[FIX] partner-contact CI interactions

(cherry picked from commit bc93e7b)

[ADD][8.0] Backport of the 9.0 module.

(cherry picked from commit a425403)

[8.0][MIG] partner_identification backport
andhit-r pushed a commit to open-synergy/partner-contact that referenced this pull request Sep 1, 2018
(cherry picked from commit eadcae2)

Conflicts:
	partner_identification/__openerp__.py
	Set version to 8.0.1.0.0.
	Remove dependency on sales_team, as the relevant change is not
in 8.0.

Change emails to the new ones
(cherry picked from commit 3455ae6)

Update new name
(cherry picked from commit 5b592d7)

[FIX] try me on runbot link

(cherry picked from commit bd587b6)

Conflicts:
	partner_identification/README.rst
	Changed runbot to 8.0

[IMP] partner_identification: Add context override (OCA#373)

Allow for context override of validations using ``id_no_validate``
(cherry picked from commit 76c2e7b)

[10.0][IMP] partner_identification: Add field computation and inverses (OCA#419)

* [IMP] partner_identification: Add field computation and inverses
* Add methods to allow for computation and inverse of an ID field of a specific category type

* [IMP] partner_identification: Add search option

(cherry picked from commit 19c5fb6)

[FIX] partner_identification: Infinite loop in search (OCA#436)

(cherry picked from commit fa9b390)

[FIX] partner-contact CI interactions

(cherry picked from commit bc93e7b)

[ADD][8.0] Backport of the 9.0 module.

(cherry picked from commit a425403)

[8.0][MIG] partner_identification backport
andhit-r pushed a commit to open-synergy/partner-contact that referenced this pull request Sep 1, 2018
(cherry picked from commit eadcae2)

Conflicts:
	partner_identification/__openerp__.py
	Set version to 8.0.1.0.0.
	Remove dependency on sales_team, as the relevant change is not
in 8.0.

Change emails to the new ones
(cherry picked from commit 3455ae6)

Update new name
(cherry picked from commit 5b592d7)

[FIX] try me on runbot link

(cherry picked from commit bd587b6)

Conflicts:
	partner_identification/README.rst
	Changed runbot to 8.0

[IMP] partner_identification: Add context override (OCA#373)

Allow for context override of validations using ``id_no_validate``
(cherry picked from commit 76c2e7b)

[10.0][IMP] partner_identification: Add field computation and inverses (OCA#419)

* [IMP] partner_identification: Add field computation and inverses
* Add methods to allow for computation and inverse of an ID field of a specific category type

* [IMP] partner_identification: Add search option

(cherry picked from commit 19c5fb6)

[FIX] partner_identification: Infinite loop in search (OCA#436)

(cherry picked from commit fa9b390)

[FIX] partner-contact CI interactions

(cherry picked from commit bc93e7b)

[ADD][8.0] Backport of the 9.0 module.

(cherry picked from commit a425403)

[8.0][MIG] partner_identification backport
tarteo pushed a commit to tarteo/partner-contact that referenced this pull request Oct 24, 2018
Allow for context override of validations using ``id_no_validate``
NL66278 pushed a commit to NL66278/partner-contact that referenced this pull request Feb 22, 2019
(cherry picked from commit eadcae2)

Conflicts:
	partner_identification/__openerp__.py
	Set version to 8.0.1.0.0.
	Remove dependency on sales_team, as the relevant change is not
in 8.0.

Change emails to the new ones
(cherry picked from commit 3455ae6)

Update new name
(cherry picked from commit 5b592d7)

[FIX] try me on runbot link

(cherry picked from commit bd587b6)

Conflicts:
	partner_identification/README.rst
	Changed runbot to 8.0

[IMP] partner_identification: Add context override (OCA#373)

Allow for context override of validations using ``id_no_validate``
(cherry picked from commit 76c2e7b)

[10.0][IMP] partner_identification: Add field computation and inverses (OCA#419)

* [IMP] partner_identification: Add field computation and inverses
* Add methods to allow for computation and inverse of an ID field of a specific category type

* [IMP] partner_identification: Add search option

(cherry picked from commit 19c5fb6)

[FIX] partner_identification: Infinite loop in search (OCA#436)

(cherry picked from commit fa9b390)

[FIX] partner-contact CI interactions

(cherry picked from commit bc93e7b)

[ADD][8.0] Backport of the 9.0 module.

(cherry picked from commit a425403)

[8.0][MIG] partner_identification backport
victormmtorres pushed a commit to Tecnativa/partner-contact that referenced this pull request Mar 25, 2019
Allow for context override of validations using ``id_no_validate``
Laurent-Corron pushed a commit to acsone/partner-contact that referenced this pull request Nov 26, 2019
Allow for context override of validations using ``id_no_validate``
ntsirintanis pushed a commit to ntsirintanis/partner-contact that referenced this pull request Feb 11, 2020
Allow for context override of validations using ``id_no_validate``
ntsirintanis pushed a commit to ntsirintanis/partner-contact that referenced this pull request Feb 19, 2020
Allow for context override of validations using ``id_no_validate``
manuelcalerosolis pushed a commit to Tecnativa/partner-contact that referenced this pull request Mar 24, 2020
Allow for context override of validations using ``id_no_validate``
phuctranfxvn pushed a commit to phuctranfxvn/partner-contact that referenced this pull request Feb 12, 2021
Allow for context override of validations using ``id_no_validate``
Freni-OSI pushed a commit to ursais/partner-contact that referenced this pull request May 9, 2022
Allow for context override of validations using ``id_no_validate``
Olageibol pushed a commit to BDO-ES/partner-contact that referenced this pull request Jun 6, 2022
Allow for context override of validations using ``id_no_validate``
marielejeune pushed a commit to acsone/partner-contact that referenced this pull request Nov 9, 2022
Allow for context override of validations using ``id_no_validate``
victor-champonnois pushed a commit to coopiteasy/partner-contact that referenced this pull request Nov 28, 2022
Allow for context override of validations using ``id_no_validate``
victor-champonnois pushed a commit to coopiteasy/partner-contact that referenced this pull request Nov 28, 2022
Allow for context override of validations using ``id_no_validate``
jdidderen-noviat pushed a commit to jdidderen-noviat/partner-contact that referenced this pull request Dec 26, 2022
Allow for context override of validations using ``id_no_validate``
njeudy pushed a commit to Alusage/partner-contact that referenced this pull request Jan 19, 2023
Allow for context override of validations using ``id_no_validate``
victor-champonnois pushed a commit to coopiteasy/partner-contact that referenced this pull request Feb 3, 2023
Allow for context override of validations using ``id_no_validate``
jdidderen-noviat pushed a commit to jdidderen-noviat/partner-contact that referenced this pull request Feb 5, 2023
Allow for context override of validations using ``id_no_validate``
AungKoKoLin1997 pushed a commit to qrtl/partner-contact that referenced this pull request Aug 10, 2023
Allow for context override of validations using ``id_no_validate``
NICO-SOLUTIONS pushed a commit to NICO-SOLUTIONS/partner-contact that referenced this pull request Dec 5, 2023
Allow for context override of validations using ``id_no_validate``
NICO-SOLUTIONS pushed a commit to NICO-SOLUTIONS/partner-contact that referenced this pull request Dec 5, 2023
Allow for context override of validations using ``id_no_validate``
edlopen pushed a commit to moduon/partner-contact that referenced this pull request Mar 1, 2024
Allow for context override of validations using ``id_no_validate``
edlopen pushed a commit to moduon/partner-contact that referenced this pull request Mar 1, 2024
Allow for context override of validations using ``id_no_validate``
bizzappdev pushed a commit to BizzAppDev-Systems/partner-contact that referenced this pull request Mar 19, 2024
Allow for context override of validations using ``id_no_validate``
chaule97 pushed a commit to chaule97/partner-contact that referenced this pull request Oct 2, 2024
Allow for context override of validations using ``id_no_validate``
chaule97 pushed a commit to chaule97/partner-contact that referenced this pull request Oct 9, 2024
Allow for context override of validations using ``id_no_validate``
chaule97 pushed a commit to chaule97/partner-contact that referenced this pull request Oct 9, 2024
Allow for context override of validations using ``id_no_validate``
chaule97 pushed a commit to chaule97/partner-contact that referenced this pull request Oct 25, 2024
Allow for context override of validations using ``id_no_validate``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants