[FIX] partner_identification: Infinite loop in search #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasley
added a commit
to LasLabs/partner-contact
that referenced
this pull request
Jun 7, 2017
* Remove identification search feature due to issues outlined in OCA#436
|
Can you perform the search yourself and return something like |
|
Brilliant - I bet that'll work! |
lasley
force-pushed
the
bugfix/10.0/partner_identification-search
branch
from
eac621e to
ee01309
Compare
|
Good call, Pedro! |
lasley
force-pushed
the
bugfix/10.0/partner_identification-search
branch
from
ee01309 to
01812b3
Compare
lasley
added a commit
to LasLabs/partner-contact
that referenced
this pull request
Jun 7, 2017
* Reimplement identification search method to fix OCA#436
* Reimplement identification search method to fix OCA#434
lasley
force-pushed
the
bugfix/10.0/partner_identification-search
branch
from
01812b3 to
640c836
Compare
pedrobaeza
reviewed
Jun 7, 2017
| return [ | ||
| (field_name, operator, value), | ||
| id_numbers = self.env['res.partner.id_number'].search([ | ||
| ('name', operator, value), |
There was a problem hiding this comment.
Shouldn't this be field_name?
There was a problem hiding this comment.
Nope - field_name is actually irrelevant in the context of searching the res.partner.id_numbers. This was actually what was causing the infinite loop, because the domain looped back onto itself instead of the id_numbers.name
There was a problem hiding this comment.
I did miss the docblock though - field_name isn't a param anymore in this method
yajo
approved these changes
Jun 8, 2017
|
Merging for fixing the branch. |
simahawk
pushed a commit
to simahawk/partner-contact
that referenced
this pull request
Nov 29, 2017
pankk
pushed a commit
to pankk/partner-contact
that referenced
this pull request
Aug 10, 2018
(cherry picked from commit eadcae2) Conflicts: partner_identification/__openerp__.py Set version to 8.0.1.0.0. Remove dependency on sales_team, as the relevant change is not in 8.0. Change emails to the new ones (cherry picked from commit 3455ae6) Update new name (cherry picked from commit 5b592d7) [FIX] try me on runbot link (cherry picked from commit bd587b6) Conflicts: partner_identification/README.rst Changed runbot to 8.0 [IMP] partner_identification: Add context override (OCA#373) Allow for context override of validations using ``id_no_validate`` (cherry picked from commit 76c2e7b) [10.0][IMP] partner_identification: Add field computation and inverses (OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option (cherry picked from commit 19c5fb6) [FIX] partner_identification: Infinite loop in search (OCA#436) (cherry picked from commit fa9b390) [FIX] partner-contact CI interactions (cherry picked from commit bc93e7b) [ADD][8.0] Backport of the 9.0 module. (cherry picked from commit a425403) [8.0][MIG] partner_identification backport
pankk
pushed a commit
to pankk/partner-contact
that referenced
this pull request
Aug 10, 2018
(cherry picked from commit eadcae2) Conflicts: partner_identification/__openerp__.py Set version to 8.0.1.0.0. Remove dependency on sales_team, as the relevant change is not in 8.0. Change emails to the new ones (cherry picked from commit 3455ae6) Update new name (cherry picked from commit 5b592d7) [FIX] try me on runbot link (cherry picked from commit bd587b6) Conflicts: partner_identification/README.rst Changed runbot to 8.0 [IMP] partner_identification: Add context override (OCA#373) Allow for context override of validations using ``id_no_validate`` (cherry picked from commit 76c2e7b) [10.0][IMP] partner_identification: Add field computation and inverses (OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option (cherry picked from commit 19c5fb6) [FIX] partner_identification: Infinite loop in search (OCA#436) (cherry picked from commit fa9b390) [FIX] partner-contact CI interactions (cherry picked from commit bc93e7b) [ADD][8.0] Backport of the 9.0 module. (cherry picked from commit a425403) [8.0][MIG] partner_identification backport
pankk
pushed a commit
to pankk/partner-contact
that referenced
this pull request
Aug 10, 2018
(cherry picked from commit eadcae2) Conflicts: partner_identification/__openerp__.py Set version to 8.0.1.0.0. Remove dependency on sales_team, as the relevant change is not in 8.0. Change emails to the new ones (cherry picked from commit 3455ae6) Update new name (cherry picked from commit 5b592d7) [FIX] try me on runbot link (cherry picked from commit bd587b6) Conflicts: partner_identification/README.rst Changed runbot to 8.0 [IMP] partner_identification: Add context override (OCA#373) Allow for context override of validations using ``id_no_validate`` (cherry picked from commit 76c2e7b) [10.0][IMP] partner_identification: Add field computation and inverses (OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option (cherry picked from commit 19c5fb6) [FIX] partner_identification: Infinite loop in search (OCA#436) (cherry picked from commit fa9b390) [FIX] partner-contact CI interactions (cherry picked from commit bc93e7b) [ADD][8.0] Backport of the 9.0 module. (cherry picked from commit a425403) [8.0][MIG] partner_identification backport
pankk
pushed a commit
to pankk/partner-contact
that referenced
this pull request
Aug 10, 2018
(cherry picked from commit eadcae2) Conflicts: partner_identification/__openerp__.py Set version to 8.0.1.0.0. Remove dependency on sales_team, as the relevant change is not in 8.0. Change emails to the new ones (cherry picked from commit 3455ae6) Update new name (cherry picked from commit 5b592d7) [FIX] try me on runbot link (cherry picked from commit bd587b6) Conflicts: partner_identification/README.rst Changed runbot to 8.0 [IMP] partner_identification: Add context override (OCA#373) Allow for context override of validations using ``id_no_validate`` (cherry picked from commit 76c2e7b) [10.0][IMP] partner_identification: Add field computation and inverses (OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option (cherry picked from commit 19c5fb6) [FIX] partner_identification: Infinite loop in search (OCA#436) (cherry picked from commit fa9b390) [FIX] partner-contact CI interactions (cherry picked from commit bc93e7b) [ADD][8.0] Backport of the 9.0 module. (cherry picked from commit a425403) [8.0][MIG] partner_identification backport
andhit-r
pushed a commit
to open-synergy/partner-contact
that referenced
this pull request
Sep 1, 2018
(cherry picked from commit eadcae2) Conflicts: partner_identification/__openerp__.py Set version to 8.0.1.0.0. Remove dependency on sales_team, as the relevant change is not in 8.0. Change emails to the new ones (cherry picked from commit 3455ae6) Update new name (cherry picked from commit 5b592d7) [FIX] try me on runbot link (cherry picked from commit bd587b6) Conflicts: partner_identification/README.rst Changed runbot to 8.0 [IMP] partner_identification: Add context override (OCA#373) Allow for context override of validations using ``id_no_validate`` (cherry picked from commit 76c2e7b) [10.0][IMP] partner_identification: Add field computation and inverses (OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option (cherry picked from commit 19c5fb6) [FIX] partner_identification: Infinite loop in search (OCA#436) (cherry picked from commit fa9b390) [FIX] partner-contact CI interactions (cherry picked from commit bc93e7b) [ADD][8.0] Backport of the 9.0 module. (cherry picked from commit a425403) [8.0][MIG] partner_identification backport
andhit-r
pushed a commit
to open-synergy/partner-contact
that referenced
this pull request
Sep 1, 2018
(cherry picked from commit eadcae2) Conflicts: partner_identification/__openerp__.py Set version to 8.0.1.0.0. Remove dependency on sales_team, as the relevant change is not in 8.0. Change emails to the new ones (cherry picked from commit 3455ae6) Update new name (cherry picked from commit 5b592d7) [FIX] try me on runbot link (cherry picked from commit bd587b6) Conflicts: partner_identification/README.rst Changed runbot to 8.0 [IMP] partner_identification: Add context override (OCA#373) Allow for context override of validations using ``id_no_validate`` (cherry picked from commit 76c2e7b) [10.0][IMP] partner_identification: Add field computation and inverses (OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option (cherry picked from commit 19c5fb6) [FIX] partner_identification: Infinite loop in search (OCA#436) (cherry picked from commit fa9b390) [FIX] partner-contact CI interactions (cherry picked from commit bc93e7b) [ADD][8.0] Backport of the 9.0 module. (cherry picked from commit a425403) [8.0][MIG] partner_identification backport
tarteo
pushed a commit
to tarteo/partner-contact
that referenced
this pull request
Oct 24, 2018
NL66278
pushed a commit
to NL66278/partner-contact
that referenced
this pull request
Feb 22, 2019
(cherry picked from commit eadcae2) Conflicts: partner_identification/__openerp__.py Set version to 8.0.1.0.0. Remove dependency on sales_team, as the relevant change is not in 8.0. Change emails to the new ones (cherry picked from commit 3455ae6) Update new name (cherry picked from commit 5b592d7) [FIX] try me on runbot link (cherry picked from commit bd587b6) Conflicts: partner_identification/README.rst Changed runbot to 8.0 [IMP] partner_identification: Add context override (OCA#373) Allow for context override of validations using ``id_no_validate`` (cherry picked from commit 76c2e7b) [10.0][IMP] partner_identification: Add field computation and inverses (OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option (cherry picked from commit 19c5fb6) [FIX] partner_identification: Infinite loop in search (OCA#436) (cherry picked from commit fa9b390) [FIX] partner-contact CI interactions (cherry picked from commit bc93e7b) [ADD][8.0] Backport of the 9.0 module. (cherry picked from commit a425403) [8.0][MIG] partner_identification backport
victormmtorres
pushed a commit
to Tecnativa/partner-contact
that referenced
this pull request
Mar 25, 2019
Laurent-Corron
pushed a commit
to acsone/partner-contact
that referenced
this pull request
Nov 26, 2019
ntsirintanis
pushed a commit
to ntsirintanis/partner-contact
that referenced
this pull request
Feb 11, 2020
ntsirintanis
pushed a commit
to ntsirintanis/partner-contact
that referenced
this pull request
Feb 19, 2020
manuelcalerosolis
pushed a commit
to Tecnativa/partner-contact
that referenced
this pull request
Mar 24, 2020
phuctranfxvn
pushed a commit
to phuctranfxvn/partner-contact
that referenced
this pull request
Feb 12, 2021
Freni-OSI
pushed a commit
to ursais/partner-contact
that referenced
this pull request
May 9, 2022
Olageibol
pushed a commit
to BDO-ES/partner-contact
that referenced
this pull request
Jun 6, 2022
marielejeune
pushed a commit
to acsone/partner-contact
that referenced
this pull request
Nov 9, 2022
victor-champonnois
pushed a commit
to coopiteasy/partner-contact
that referenced
this pull request
Nov 28, 2022
victor-champonnois
pushed a commit
to coopiteasy/partner-contact
that referenced
this pull request
Nov 28, 2022
jdidderen-noviat
pushed a commit
to jdidderen-noviat/partner-contact
that referenced
this pull request
Dec 26, 2022
njeudy
pushed a commit
to Alusage/partner-contact
that referenced
this pull request
Jan 19, 2023
victor-champonnois
pushed a commit
to coopiteasy/partner-contact
that referenced
this pull request
Feb 3, 2023
jdidderen-noviat
pushed a commit
to jdidderen-noviat/partner-contact
that referenced
this pull request
Feb 5, 2023
AungKoKoLin1997
pushed a commit
to qrtl/partner-contact
that referenced
this pull request
Aug 10, 2023
NICO-SOLUTIONS
pushed a commit
to NICO-SOLUTIONS/partner-contact
that referenced
this pull request
Dec 5, 2023
NICO-SOLUTIONS
pushed a commit
to NICO-SOLUTIONS/partner-contact
that referenced
this pull request
Dec 5, 2023
edlopen
pushed a commit
to moduon/partner-contact
that referenced
this pull request
Mar 1, 2024
edlopen
pushed a commit
to moduon/partner-contact
that referenced
this pull request
Mar 1, 2024
bizzappdev
pushed a commit
to BizzAppDev-Systems/partner-contact
that referenced
this pull request
Mar 19, 2024
chaule97
pushed a commit
to chaule97/partner-contact
that referenced
this pull request
Oct 2, 2024
chaule97
pushed a commit
to chaule97/partner-contact
that referenced
this pull request
Oct 9, 2024
chaule97
pushed a commit
to chaule97/partner-contact
that referenced
this pull request
Oct 9, 2024
chaule97
pushed a commit
to chaule97/partner-contact
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements the partner_identification search method to fix #434