Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][MIG] partner_identification backport #612

Merged
merged 1 commit into from
Sep 1, 2018

Conversation

pankk
Copy link
Member

@pankk pankk commented Jul 19, 2018

Backport of partner_identification, based on the 10.0 version which adds additional features. These features are required for the partner_coc PR here: #605

@pankk pankk force-pushed the 8.0-partner-identification-backport branch from 6c8da51 to 4c12b3a Compare July 19, 2018 09:55
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix this:
partner_identification/README.rst:18: [E7901(rst-syntax-error), ] Unexpected possible title overline or transition.|Treating it as ordinary text because it's so short.

'views/res_partner_id_category_view.xml',
'views/res_partner_id_number_view.xml',
'views/res_partner_view.xml',
'security/ir.model.access.csv',
],
'author': 'ChriCar Beteiligungs- und Beratungs- GmbH, '
'Antiun Ingeniería S.L.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the comma inside the string

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tarteo, I will cherry-pick the commits from 11.0 that solve this (and some other) issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update Antiun author to the new company Tecnativa?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza Yes, I've seen commits that push that change and will cherry-pick them. Thanks!

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Returns:
list: Domain to search with.
"""
id_numbers = self.env['res.partner.id_number'].search([
Copy link
Contributor

@rousseldenis rousseldenis Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pankk Avoid this (I know this is on v11 - I'll try to fix it later).

It's not necessary to do a search before returning (two queries instead of one).


return [
    ('id_numbers.name', operator, value),
    ('id_numbers.category_id.code', '=', category_code),
]

It will impact performances.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get #434 when doing it like this. Can we go with @pedrobaeza's suggestion in #436?
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pankk Yes, I was not aware of that bug. Ok for me

@pankk pankk force-pushed the 8.0-partner-identification-backport branch 3 times, most recently from f401813 to 3699e53 Compare August 10, 2018 19:28
(cherry picked from commit eadcae2)

Conflicts:
	partner_identification/__openerp__.py
	Set version to 8.0.1.0.0.
	Remove dependency on sales_team, as the relevant change is not
in 8.0.

Change emails to the new ones
(cherry picked from commit 3455ae6)

Update new name
(cherry picked from commit 5b592d7)

[FIX] try me on runbot link

(cherry picked from commit bd587b6)

Conflicts:
	partner_identification/README.rst
	Changed runbot to 8.0

[IMP] partner_identification: Add context override (OCA#373)

Allow for context override of validations using ``id_no_validate``
(cherry picked from commit 76c2e7b)

[10.0][IMP] partner_identification: Add field computation and inverses (OCA#419)

* [IMP] partner_identification: Add field computation and inverses
* Add methods to allow for computation and inverse of an ID field of a specific category type

* [IMP] partner_identification: Add search option

(cherry picked from commit 19c5fb6)

[FIX] partner_identification: Infinite loop in search (OCA#436)

(cherry picked from commit fa9b390)

[FIX] partner-contact CI interactions

(cherry picked from commit bc93e7b)

[ADD][8.0] Backport of the 9.0 module.

(cherry picked from commit a425403)

[8.0][MIG] partner_identification backport
@pankk pankk force-pushed the 8.0-partner-identification-backport branch from 3699e53 to 3e7004b Compare August 10, 2018 19:41
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint error seems not to be related to this module.

@pedrobaeza
Copy link
Member

Merging as the lint error is unrelated

@pedrobaeza pedrobaeza merged commit 79cfc58 into OCA:8.0 Sep 1, 2018
@pankk pankk deleted the 8.0-partner-identification-backport branch September 3, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants