[IMP] product_state (copy=False) #1074
Conversation
|
Hi @emagdalenaC2i, |
|
@dreispt can you please review. |
There was a problem hiding this comment.
Comment (non blocking) : state is a caracteristic of the product so it is attended by the user to preserve the information when duplicate. Why do you think that empty value is better than the value of the duplicated item ?
Note : i personnaly dont use this module.
|
@legalsylvain I'm not sure I understand what you mean about 'empty value' as it wouldn't be an empty value but instead the newly copied product would default to the stage that has the is_default set. |
There was a problem hiding this comment.
@patrickrwilson Could you add a little test for this change ?
Ah, sorry. I didn't know the interaction between regards. |
patrickrwilson
force-pushed
the
product_state_copy_false
branch
from
5d73a9e
to
960da43
Compare
|
FYI: I'll be fixing the new test |
The product state shouldn't be copied when copying the product so this adds copy=False to the state field. [IMP] product_state: Add test for copy [FIX] Test
patrickrwilson
force-pushed
the
product_state_copy_false
branch
from
960da43
to
5e7d575
Compare
|
@legalsylvain "state" is computed based on "Stage" - is groups the dynamic and configurable Stages list into specific state codes. |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
This PR has the |
|
Congratulations, your PR was merged at 4c210a4. Thanks a lot for contributing to OCA. ❤️ |
The product state shouldn't be copied when copying the product so this adds copy=False to the state field.