[17.0][FW] product_state: multiple ports from 14.0

[henrybackman]

Port of the following PRs from 14.0 to 17.0:

• [IMP] product_state (copy=False) #1074
• [14.0][IMP] product_state: move access to Sales + Inventory Manager #1124

[OCA-git-bot]

Hi @emagdalenaC2i,
some modules you are maintaining are being modified, check this out!

[henrybackman]

Tests from another module uom_category_active are failing but I am not able to connect them to the changes done in this PR. Unsure how to proceed.

[ivantodorovich]

Even if unrelated, we'll need to investigate and fix it in order to merge this one :/

Having a quick look on the failing module.. I honestly don't understand how that test managed to originally succeed.
It seems contradictory to the actual code.

product-attribute/uom_category_active/tests/test_uom_category_active.py

Lines 28 to 34 in 5a79222

	def test_archive_reference_uom(self):
	self.assertTrue(self.uom_categ.active)
	uom = self.uom_categ.uom_ids[0]
	self.assertTrue(uom.active)
	uom.active = False
	with self.assertRaises(UserError):
	self.uom_categ._onchange_uom_ids()

product-attribute/uom_category_active/models/uom_category.py

Lines 22 to 25 in 5a79222

	@api.onchange("uom_ids")
	def _onchange_uom_ids(self):
	if self.active:
	return super()._onchange_uom_ids()

My recommendation: remove the assertRaises lines in a separate PR, pinging the module author to check

[henrybackman]

@ivantodorovich Seems like this test failure is not related to this and affects all PRs:

• [16.0][TEST] Do not merge. Test uom_category_active CI #1754

[simahawk]

CI fixed on #1760

[simahawk]

/ocabot merge minor

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1755-by-simahawk-bump-minor, awaiting test results.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[OCA-git-bot]

Congratulations, your PR was merged at 21171af. Thanks a lot for contributing to OCA. ❤️